1083591 - We don't correctly codegen stringifiers and jsonifiers on non-concrete interfaces

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

That block in Configuration.py is in with the named/indexed prop stuff, but that affects the JSClass, so is only done for concrete interfaces, whereas stringifier/jsonifier makes sense on all interfaces, since it just corresponds to methods on the prototype.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Support stringifiers and jsonifiers on non-concrete Web IDL interfaces as well, since they make sense there

Comment 2

[Peter Van der Beken [:peterv]]

Comment on attachment 8505886 [details] [diff] [review]
Support stringifiers and jsonifiers on non-concrete Web IDL interfaces as well, since they make sense there

Review of attachment 8505886 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bindings/Configuration.py
@@ +334,5 @@
>                      addOperation('Stringifier', m)
>                  if m.isMethod() and m.isJsonifier():
>                      addOperation('Jsonifier', m)
> +
> +        if self.concrete:

So now we loop twice, not sure if we care. But if we do, you could use one loop and continue here.

Comment 3

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e82fd502119c and then https://hg.mozilla.org/integration/mozilla-inbound/rev/6f5ba08ca1b9 to fix the resulting bustage; that's what I get for testing this on _top_ of bug 1082663's patch.

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e82fd502119c
https://hg.mozilla.org/mozilla-central/rev/6f5ba08ca1b9