Closed
Bug 1083611
Opened 10 years ago
Closed 10 years ago
Use fallible new for large allocations, infallible otherwise
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: jgilbert, Assigned: jgilbert)
Details
Attachments
(1 file)
8.22 KB,
patch
|
u480271
:
review+
lmandel
:
approval-mozilla-aurora+
lmandel
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
We still have some large infallible allocations. Let's fix that.
Attachment #8505917 -
Flags: review?(dglastonbury)
Attachment #8505917 -
Flags: review?(dglastonbury) → review+
Assignee | ||
Comment 1•10 years ago
|
||
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=0b0fed3464be
Assignee | ||
Comment 2•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/effa5aa63883
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8505917 [details] [diff] [review] 0001-Use-UniquePtr-and-fallible-allocations.patch Approval Request Comment [Feature/regressing bug #]: n/a [User impact if declined]: Higher likelihood of OOMs from infallible allocations. [Describe test coverage new/current, TBPL]: No specific tests, green on try. [Risks and why]: Very low. It's a relatively pure safety win. [String/UUID change made/needed]: none
Attachment #8505917 -
Flags: approval-mozilla-beta?
Attachment #8505917 -
Flags: approval-mozilla-aurora?
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/effa5aa63883
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Updated•10 years ago
|
Comment 5•10 years ago
|
||
Comment on attachment 8505917 [details] [diff] [review] 0001-Use-UniquePtr-and-fallible-allocations.patch Beta+ Aurora+
Attachment #8505917 -
Flags: approval-mozilla-beta?
Attachment #8505917 -
Flags: approval-mozilla-beta+
Attachment #8505917 -
Flags: approval-mozilla-aurora?
Attachment #8505917 -
Flags: approval-mozilla-aurora+
Comment 6•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/676409f0e83c https://hg.mozilla.org/releases/mozilla-beta/rev/42f43b1c896e
Comment 7•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/42f43b1c896e
status-b2g-v2.1:
--- → fixed
status-b2g-v2.2:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•