Closed Bug 1083611 Opened 5 years ago Closed 5 years ago

Use fallible new for large allocations, infallible otherwise

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla36
Tracking Status
firefox34 --- fixed
firefox35 --- fixed
firefox36 --- fixed
b2g-v2.1 --- fixed
b2g-v2.2 --- fixed

People

(Reporter: jgilbert, Assigned: jgilbert)

Details

Attachments

(1 file)

We still have some large infallible allocations. Let's fix that.
Attachment #8505917 - Flags: review?(dglastonbury)
Attachment #8505917 - Flags: review?(dglastonbury) → review+
Comment on attachment 8505917 [details] [diff] [review]
0001-Use-UniquePtr-and-fallible-allocations.patch

Approval Request Comment
[Feature/regressing bug #]: n/a
[User impact if declined]: Higher likelihood of OOMs from infallible allocations.
[Describe test coverage new/current, TBPL]: No specific tests, green on try.
[Risks and why]: Very low. It's a relatively pure safety win.
[String/UUID change made/needed]: none
Attachment #8505917 - Flags: approval-mozilla-beta?
Attachment #8505917 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/effa5aa63883
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Comment on attachment 8505917 [details] [diff] [review]
0001-Use-UniquePtr-and-fallible-allocations.patch

Beta+
Aurora+
Attachment #8505917 - Flags: approval-mozilla-beta?
Attachment #8505917 - Flags: approval-mozilla-beta+
Attachment #8505917 - Flags: approval-mozilla-aurora?
Attachment #8505917 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.