1083611 - Use fallible new for large allocations, infallible otherwise

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Kelsey Gilbert [:jgilbert]]

Attachment: 0001-Use-UniquePtr-and-fallible-allocations.patch

We still have some large infallible allocations. Let's fix that.

Comment 1

[Kelsey Gilbert [:jgilbert]]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=0b0fed3464be

Comment 2

[Kelsey Gilbert [:jgilbert]]

  https://hg.mozilla.org/integration/mozilla-inbound/rev/effa5aa63883

Comment 3

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8505917 [details] [diff] [review]
0001-Use-UniquePtr-and-fallible-allocations.patch

Approval Request Comment
[Feature/regressing bug #]: n/a
[User impact if declined]: Higher likelihood of OOMs from infallible allocations.
[Describe test coverage new/current, TBPL]: No specific tests, green on try.
[Risks and why]: Very low. It's a relatively pure safety win.
[String/UUID change made/needed]: none

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/effa5aa63883

Comment 5

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8505917 [details] [diff] [review]
0001-Use-UniquePtr-and-fallible-allocations.patch

Beta+
Aurora+

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/676409f0e83c
https://hg.mozilla.org/releases/mozilla-beta/rev/42f43b1c896e

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/42f43b1c896e