1083638 - Implement a promise queue to govern the loading/unloading of keyboard layouts

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Currently loading/unloading concurrency is prevented in various places in keyboard app. Let me centralize that in the StateManager by implementing a AbortablePromiseQueue so that we can ensure nothing is run in parallel from state changes.

It would be an improved patch from bug 1077124 comment 11.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Github: https://github.com/mozilla-b2g/gaia/pull/25252

This pull request implements an AbortablePromiseQueue interface, and adds a marionette test for testing switching between inputs of the same frame.

Comment 2

[John Lu [:mnjul][Please NI or I'll miss]]

Comment on attachment 8506685 [details] [review]
Github: https://github.com/mozilla-b2g/gaia/pull/25252

The architecture looks good, but as offline discussed, unfortunately that never-ending Promise chaining seems to not play well with Gecko. Let's see how bug 1084324 turns out.

Comment 3

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8506685 [details] [review]
Github: https://github.com/mozilla-b2g/gaia/pull/25252

Looks good to me as well.
Thanks.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=ca1fc0468eae

master: https://github.com/mozilla-b2g/gaia/commit/ac5e0a098034bcb4a944489a5b57d40abf6927ba