1083701 - Inherit stdout/err for sandboxed process pre-Vista for testing purposes.

Status: RESOLVED FIXED

(Core :: Security, defect)

Description

[Bob Owen (:bobowen)]

We don't normally inherit stdout/err pre-Vista because it means we have to inherit all inheritable handles.
However, some tests require stdout/err to be inherited for the test logging to work.
Bug 1037445 added a new environment variable (MOZ_WIN_INHERIT_STD_HANDLES_PRE_VISTA) to indicate that stdout/err should be inherited for e10s.
We need to use this in the sandboxing process launch code as well.

Comment 1

[Bob Owen (:bobowen)]

Attachment: When pre-Vista, for testing purposes allow stdout/err to be inherited by sandboxed process when an env var is set.

This is very similar to the patch for bug 1037445, except that I've used getenv instead of PR_GetEnv because I won't be able to bind to it.

This is another change to chromium code, but I don't see any way round it.

Try push for WinXP test:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=878c3fb604c1

Comment 2

[Bob Owen (:bobowen)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f94a07671389

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f94a07671389