Closed Bug 1083701 Opened 10 years ago Closed 10 years ago

Inherit stdout/err for sandboxed process pre-Vista for testing purposes.

Categories

(Core :: Security, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: bobowen, Assigned: bobowen)

References

Details

Attachments

(1 file)

We don't normally inherit stdout/err pre-Vista because it means we have to inherit all inheritable handles.
However, some tests require stdout/err to be inherited for the test logging to work.
Bug 1037445 added a new environment variable (MOZ_WIN_INHERIT_STD_HANDLES_PRE_VISTA) to indicate that stdout/err should be inherited for e10s.
We need to use this in the sandboxing process launch code as well.
This is very similar to the patch for bug 1037445, except that I've used getenv instead of PR_GetEnv because I won't be able to bind to it.

This is another change to chromium code, but I don't see any way round it.

Try push for WinXP test:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=878c3fb604c1
Attachment #8506132 - Flags: review?(tabraldes)
Attachment #8506132 - Flags: review?(tabraldes) → review+
https://hg.mozilla.org/mozilla-central/rev/f94a07671389
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.