1083717 - Notifications text in utility tray slightly truncated in some locales

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Guillaume Marty [:gmarty]]

Attachment: 2014-10-16-10-48-12.png

Because the Notifications title in the utility tray is in italic, it is slightly cut on the right hand side.
This appears mostly on locale non using latin script (Japanese, Chinese, languages spoken in India...)

Comment 1

[Zac C (:zac)]

Which build, master?

I am on v2.1 and this same text is not truncated because it is not italicized.

Comment 2

[Guillaume Marty [:gmarty]]

Attachment: Github PR

The fix is one liner. Etienne, can you give me a r+ on that?

Comment 3

[Etienne Segonzac (:etienne)]

Comment on attachment 8506840 [details] [review]
Github PR

Sorry but I don't understand the bug.
#notification-some is not fixed-width, why are we overflowing?

If we need to work around a platform issue we should file it first and reference it in a comment.

Comment 4

[Guillaume Marty [:gmarty]]

Comment on attachment 8506840 [details] [review]
Github PR

I agree with you about the riskiness of removing the overflow hidden here.
Fixing this issue with a non breaking space for 2.1 (v2.2 uses flexbox since Bug 1062314 landed but it was decided not to uplift it).

Also added some context in a comment.

Comment 5

[Guillaume Marty [:gmarty]]

Related to Bug 1086211

Comment 6

[Etienne Segonzac (:etienne)]

Comment on attachment 8506840 [details] [review]
Github PR

perfect, thanks!
(let's make sure we get a green try, we might have test inspecting this part of the DOM)

Comment 7

[Guillaume Marty [:gmarty]]

Comment on attachment 8506840 [details] [review]
Github PR

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Utility tray visual refresh
[User impact] if declined: Some characters can be cropped on the utility tray on some languages (including markets where we launched).
[Testing completed]: Manual testing
[Risk to taking this patch] (and alternatives if risky): Very low as it is just a one-liner
[String changes made]: None

Comment 8

[bhavana bajaj [:bajaj]]

(In reply to Guillaume Marty [:gmarty] from comment #7)
> Comment on attachment 8506840 [details] [review]
> Github PR
> 
> [Approval Request Comment]
> [Bug caused by] (feature/regressing bug #): Utility tray visual refresh
> [User impact] if declined: Some characters can be cropped on the utility
> tray on some languages (including markets where we launched).
> [Testing completed]: Manual testing
> [Risk to taking this patch] (and alternatives if risky): Very low as it is
> just a one-liner
> [String changes made]: None

Is this a 2.1 regression? The patch looks simple/low risk and should be fine to get landed once resolved on trunk, but I want to confirm if we landed something in 2.1 that regressed this or are you seeing the same behavior in 2.0 as well ?

Comment 9

[Guillaume Marty [:gmarty]]

It's not a regression as the utility tray visual refresh first landed in v2.1 (v2.0 still has the same old look since v1.3).

Comment 10

[[:fabrice] Fabrice Desré]

Does that work well with LTR locales?

Comment 11

[[:fabrice] Fabrice Desré]

(In reply to Fabrice Desré [:fabrice] from comment #10)
> Does that work well with LTR locales?

And... I meant RTL of course!

Comment 12

[Guillaume Marty [:gmarty]]

Comment on attachment 8506840 [details] [review]
Github PR

Good call Fabrice, this bug appears on Arabic too. The patch now uses padding-right instead of the non breaking space that is direction sensitive.
I checked under several locales configuration and it doesn't appear to have any bad side effects. Etienne, can you please review it?

Comment 13

[Etienne Segonzac (:etienne)]

Comment on attachment 8506840 [details] [review]
Github PR

lgtm

Comment 14

[Guillaume Marty [:gmarty]]

Landed in v2.1 branch in https://github.com/mozilla-b2g/gaia/commit/5a3e34fb6d1299a4cb272db843c40f40c2febc5f

Comment 15

[[:fabrice] Fabrice Desré]

(In reply to Guillaume Marty [:gmarty] from comment #14)
> Landed in v2.1 branch in
> https://github.com/mozilla-b2g/gaia/commit/
> 5a3e34fb6d1299a4cb272db843c40f40c2febc5f

So... you landed on 2.1 before getting approval?

Comment 16

[Guillaume Marty [:gmarty]]

I had completely forgot I needed approval before landing v2.1 specific bugs. Shall I request approval now?
Bug 1082935 is in the same case. I'm sorry about that.

Comment 17

[[:fabrice] Fabrice Desré]

(In reply to Guillaume Marty [:gmarty] from comment #16)
> I had completely forgot I needed approval before landing v2.1 specific bugs.
> Shall I request approval now?
> Bug 1082935 is in the same case. I'm sorry about that.

Yes, you need backout Bug 1082935 from 2.1 and reland once you have approval. Only master doesn't need approval.

Comment 18

[Brogan Zumwalt [Inactive]]

Issue verified fixed on Flame 2.1 & Flame 2.2

Actual Results: All available non-latin locales show Notifications header text that is not cut off. Same was tested on 2.2 to the extent translations exist for build.


Device: Flame 2.1 (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141031001201
Gaia: f89c7b12c36572262c9ea76058694a139b1a8634
Gecko: 50d48f8a04c7
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 34.0 (2.1)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Device: Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141031061804
Gaia: a07994714f0552f89801d6097982308d8b0a1ee1
Gecko: 6bd2071b373f
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 36.0a1 (2.2) 
Firmware Version: v188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0