Closed Bug 1083733 Opened 6 years ago Closed 6 years ago

[Contacts] Contact search higlights more letters than input on the search

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: arcturus, Assigned: matarrese, Mentored)

References

Details

(Whiteboard: [good-first-bug])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
arcturus
: review+
Details | Review
Current search matches more letters than input on the search.

STR:
- Have a contact with name 'Aaaaaa'
- Make a search with 'aaa'

Actual:
- 'Aaaaaa' is highlighted

Expected:
- 'Aaa' should be highlighted
Here is more info:

https://bug1074643.bugzilla.mozilla.org/attachment.cgi?id=8505966
See Also: → 1074643
Whiteboard: [good-first-bug]
I think this is provoked by my patch when I fixed highlighting a couple of months ago. I made that behavior on purpose so, for example, if you search for 'jo' you see highlighted "'Jo'sé 'Jo'vellanos". I understand that the STR you described makes the highlighting somewhat confusing, but it is a really strange case and fixing it may break highlighting things like the one I described in the example.

Hope this helps!
Flags: needinfo?(francisco)
Thanks Adrian,

we will need to fix it anyway, and without breaking stuff.

That's why we have unit test for ;)
Flags: needinfo?(francisco)
Attached file Github pull request
Hi francisco, this bug need to be reviewed and checked if the new behaviour is the expected one
Attachment #8515497 - Flags: review?(francisco)
Thanks Antonio for working on this!
Assignee: nobody → matarrese
Comment on attachment 8515497 [details] [review]
Github pull request

Looks good, thanks for the contribution
Attachment #8515497 - Flags: review?(francisco) → review+
Landed in master:

https://github.com/mozilla-b2g/gaia/commit/1b5a5cf8a6dbdc013f59297d40c4fd7275fad31a

Thanks for the contribution.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.