1083733 - [Contacts] Contact search higlights more letters than input on the search

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Francisco Jordano [:arcturus] [:francisco]]

Current search matches more letters than input on the search.

STR:
- Have a contact with name 'Aaaaaa'
- Make a search with 'aaa'

Actual:
- 'Aaaaaa' is highlighted

Expected:
- 'Aaa' should be highlighted

Comment 1

[Francisco Jordano [:arcturus] [:francisco]]

Here is more info:

https://bug1074643.bugzilla.mozilla.org/attachment.cgi?id=8505966

Comment 2

[Adrián de la Rosa]

I think this is provoked by my patch when I fixed highlighting a couple of months ago. I made that behavior on purpose so, for example, if you search for 'jo' you see highlighted "'Jo'sé 'Jo'vellanos". I understand that the STR you described makes the highlighting somewhat confusing, but it is a really strange case and fixing it may break highlighting things like the one I described in the example.

Hope this helps!

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Thanks Adrian,

we will need to fix it anyway, and without breaking stuff.

That's why we have unit test for ;)

Comment 4

[Antonio Matarrese]

Attachment: Github pull request

Hi francisco, this bug need to be reviewed and checked if the new behaviour is the expected one

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Thanks Antonio for working on this!

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8515497 [details] [review]
Github pull request

Looks good, thanks for the contribution

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Landed in master:

https://github.com/mozilla-b2g/gaia/commit/1b5a5cf8a6dbdc013f59297d40c4fd7275fad31a

Thanks for the contribution.