Closed Bug 1083895 Opened 7 years ago Closed 7 years ago
Element not in DOM is used for favicon
Not sure if it's a valid bug, anyway: Regression range: good=2014-07-11 bad=2014-07-12 http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e1a037c085d1&tochange=b0701d069bf9 suspected bug: Gijs Kruitbosch — Bug 577892 - allow icons to change when href attribute is set directly, with automated test, r=dolske,bz
I expect this is an actual regression, yes. Redirecting to bz to be sure.
Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(bzbarsky)
Yeah. We should probably not fire DOMLinkChanged for <link>s that are not in the DOM.
Like this? Note that I've not tried to actually think hard about shadow DOM or any other edge cases... I don't think there are any? But then, the name 'IsInUncomposedDoc' is not very clear and so I'm not sure if this should change the result here...
Attachment #8506345 - Flags: review?(bzbarsky)
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Comment on attachment 8506345 [details] [diff] [review] favicon should not change if link element isn't in DOM, I think this is what you want, yes. IsInUncomposedDoc() means "in document, not in shadow DOM". Naming is hard; we spent about a week trying to come up with good names for this stuff. :(
Attachment #8506345 - Flags: review?(bzbarsky) → review+
Comment on attachment 8506345 [details] [diff] [review] favicon should not change if link element isn't in DOM, Approval Request Comment [Feature/regressing bug #]: bug 577892 [User impact if declined]: merely creating a new link element and setting its href will cause issues [Describe test coverage new/current, TBPL]: has automated test [Risks and why]: pretty low, specific fix to check if the new link element is in the document when the href is set [String/UUID change made/needed]: nope
Iteration: --- → 36.1
Comment on attachment 8506345 [details] [diff] [review] favicon should not change if link element isn't in DOM, Beta+ Aurora+
Confirming the fix for latest Nightly, build ID: 20141019030207 using the attached test case.
Verified fixed on Firefox 34 beta 2, build ID: 20141020184313.
You need to log in before you can comment on or make changes to this bug.