1083934 - Google calendar provider ignores default new event/task reminder setting

Status: RESOLVED FIXED

(Calendar :: Provider: GData, defect, P1)

Description

[Mitch Claborn]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:33.0) Gecko/20100101 Firefox/33.0
Build ID: 20141013200257

Steps to reproduce:

Thunderbird 31.2.0
Lightning 3.3.1
Ubuntu 14.04

When the "Provider for Google Calendar 1.0.1" is enabled, the new task dialog ignores the default setting for task reminder in the preferences and starts with "no reminder".

1) In Calendar preferences set "Default time a reminder is set before a task" to "0 minutes"
2) Create a new task


Actual results:

The default reminder is "No reminder"


Expected results:

Default reminder should be "0 minutes before"

Comment 3

[Martin Pecka]

I also face this error with Provider 1.0.2.

Discussion with author here: https://groups.google.com/forum/#!searchin/provider-for-google-calendar/default/provider-for-google-calendar/7SdAxAYZRdA/HKYPoPEFf1MJ

Comment 4

[Martin Pecka]

I'd like to add that if the Provider is enabled, the described behavior can be seen even with non-Google (CalDAV, local) calendars.

Comment 5

[Sven Giermann]

Attachment: patch for gdata-calendar-event-dialog.js

Sorry, I'm with other projects atm, but I got argued by this bug too.
The attached patch (created from 1.0.2 shipped version) at least corrects this behaviour for non-Google calendars. The provider should not touch non-Google calendars at all...
It has to be discussed, whether we need to have a different reminder setting in GData Provider separated from Google settings - I mean, whether we want to keep the Lightning default reminder for Google calendars that are set to have no reminder as default.

Comment 6

[Sven Giermann]

Attachment: 2nd patch for gdata-calendar-event-dialog.js

Sorry for confusion: the patch above is not working!
Indeed the loadReminders() has to be patched to make default reminders work for non-Google calendars. This second patch would be sufficient, but as stated above (reminders should only be touched for Google calendars), it would be more safe to apply the first patch as well.

Comment 7

[Sven Giermann]

Attachment: 2nd patch for gdata-calendar-event-dialog.js

Wrong direction... corrected.

Comment 8

[Mitch Claborn]

I applied both patches and the problem is corrected for me.

Comment 9

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 8531540 [details] [diff] [review]
patch for gdata-calendar-event-dialog.js

Thanks for the patches. I've applied them locally, will release them as part of 1.0.3 and then make sure the result is committed to comm-central in bug 1079189 afterwards.

I'm marking this as FIXED even though its not committed yet. The process for the 1.0.x releases is a bit messy, I apologize.

Comment 10

[Sven Giermann]

At least in version 4.4.1 we have a regression of this bug, although I already checked the code and it should exit when not operating on a Google calendar (gdata-event-dialog-reminder.js).
But again, when I disable the addon, the default alarm is being set on new events.

Should we reopen this bug or file a new one?

Comment 11

[[:MakeMyDay]]

Please file a new one - we shouldn't reopen a bug that has been fixed for about four years now.

Comment 12

[Mitch Claborn]

Please post the new bug ID here so others can follow it.

Comment 13

[Russ Hansen]

Is this new activity a dupe of bug 1481043?

Comment 14

[Sven Giermann]

Yes, I already found bug 1481043, applied the provided patch and it works again. So it's very likely to see an updated version of the provider soon!