1084039 - Clean up AnimationPlayerCollection::PseudoElement()

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Daniel Holbert [:dholbert]]

Right now, AnimationPlayerCollection::PseudoElement() looks like this:

254   nsString PseudoElement()
255   {
256     if (IsForElement()) {
257       return EmptyString();
258     } else if (IsForBeforePseudo()) {
259       return NS_LITERAL_STRING("::before");
260     } else {
261       return NS_LITERAL_STRING("::after");
262     }
263   }

http://mxr.mozilla.org/mozilla-central/source/layout/style/AnimationCommon.h?rev=a014629454d0#254

Three things that I think should change:
 (1) It should be marked as "const"
 (2) We should drop "else" after return
 (3) In the third case, we should probably assert that "IsForAfterPseudo()" is true, to sanity-check that we don't accidentally fall into that final "return" for a non-::after scenario.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix v1

Comment 2

[Daniel Holbert [:dholbert]]

Thanks! Landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/375f9239e689

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/375f9239e689