Closed Bug 1084100 Opened 5 years ago Closed 5 years ago

Move reader logic out of BrowserToolbar

Categories

(Firefox for Android :: General, defect)

35 Branch
All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 36

People

(Reporter: Margaret, Assigned: Margaret)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

This is similar to bug 1078355. Right now we have logic in BrowserToolbar to handle clicks on the reader mode page action icon, but there's no reason for it to be in BrowserToolbar, since these event handlers don't actually do anything with the toolbar: 
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/toolbar/BrowserToolbar.java#899

In bug 1078355, I suggested making a new Java class to handle processing all these reader events, and I think this logic could go there as well.
(In reply to :Margaret Leibovic from comment #0)

> In bug 1078355, I suggested making a new Java class to handle processing all
> these reader events, and I think this logic could go there as well.

Actually, this should really just go in Tabs, since it is only doing tab-specific stuff. I'll write a patch.
Assignee: nobody → margaret.leibovic
A small step to consolidate reader mode logic. This also makes this a bit more correct, since we're not just selecting the current tab at the time Java gets the message.
Attachment #8506489 - Flags: review?(bnicholson)
Comment on attachment 8506489 [details] [diff] [review]
Move Reader:Click/LongClick event listeners out of BrowserToolbar

Review of attachment 8506489 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, I like getting rid of these random GeckoEventListeners.
Attachment #8506489 - Flags: review?(bnicholson) → review+
https://hg.mozilla.org/mozilla-central/rev/2af61439e1e8
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
You need to log in before you can comment on or make changes to this bug.