1084100 - Move reader logic out of BrowserToolbar

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[:Margaret Leibovic]

This is similar to bug 1078355. Right now we have logic in BrowserToolbar to handle clicks on the reader mode page action icon, but there's no reason for it to be in BrowserToolbar, since these event handlers don't actually do anything with the toolbar: 
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/toolbar/BrowserToolbar.java#899

In bug 1078355, I suggested making a new Java class to handle processing all these reader events, and I think this logic could go there as well.

Comment 1

[:Margaret Leibovic]

(In reply to :Margaret Leibovic from comment #0)

> In bug 1078355, I suggested making a new Java class to handle processing all
> these reader events, and I think this logic could go there as well.

Actually, this should really just go in Tabs, since it is only doing tab-specific stuff. I'll write a patch.

Comment 2

[:Margaret Leibovic]

Attachment: Move Reader:Click/LongClick event listeners out of BrowserToolbar

A small step to consolidate reader mode logic. This also makes this a bit more correct, since we're not just selecting the current tab at the time Java gets the message.

Comment 3

[Brian Nicholson (:bnicholson)]

Comment on attachment 8506489 [details] [diff] [review]
Move Reader:Click/LongClick event listeners out of BrowserToolbar

Review of attachment 8506489 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, I like getting rid of these random GeckoEventListeners.

Comment 4

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/2af61439e1e8

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2af61439e1e8