1084116 - clicking on "Treeherder" or "jobs" at the top takes me to mozilla-central

Status: VERIFIED FIXED

(Tree Management :: Treeherder, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

If I click on the "Treeherder" or "jobs" words at the top of https://treeherder.mozilla.org/ui/#/jobs?repo=try&author=[e-mail] it takes me to a view showing the jobs on mozilla-central.  That doesn't make sense -- it doesn't make sense for those things to lead to an action that is "switch trees and remove filters".

I think those things either shouldn't be links, or they should do something more sensible given the context.

Comment 1

[Mauro Doglio [:mdoglio]]

I agree, let's remove "jobs" and make "Treeherder" a label.

Comment 2

[Jonathan French (:jfrench)]

I have this mostly done. One tweak tbd, and just poking around in case there's any underlying bits to clean up outside the markup.

Comment 3

[Jonathan French (:jfrench)]

Attachment: treeherder-ui-PR#247

Please see the above PR for review and status. Adding Ed for Sheriff sign-off.

Comment 4

[Ed Morley [:emorley]]

Comment on attachment 8510816 [details] [review]
treeherder-ui-PR#247

We'll want to add some navigation back once we have multiple views {"jobs", "timeline", "machines", "perf", ...} but this improves things short term :-)

Comment 5

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/6771e9e2ed11c7bf9688fe2628c548e1a83d6a94
Bug 1084116 - Remove nav on logo and jobs button to preserve user state

https://github.com/mozilla/treeherder-ui/commit/ef99effe66b465328639ea2ba73e330d568fb602
Merge pull request #247 from tojonmz/remove-mainav-links

Bug 1084116 - Remove nav on logo and jobs button to preserve user state

Comment 6

[William Lachance (:wlach)]

Comment on attachment 8510816 [details] [review]
treeherder-ui-PR#247

We'll probably want to relinkify this stuff in the future as we add additional panels but this makes more sense for now.

Comment 7

[Jonathan French (:jfrench)]

Verified fixed and working correctly on dev/stage/prod.

Comment 8

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/df46ee3bb445cdd8d644f10f6ae8d50b6903e2f6
Bug 1084116 - Remove nav on logo and jobs button to preserve user state

https://github.com/mozilla/treeherder/commit/d75be91c13c1fff25e2d6723388b64591a1a4358
Merge pull request #247 from tojonmz/remove-mainav-links

Bug 1084116 - Remove nav on logo and jobs button to preserve user state