1084125 - Have marionette check the capabilities and error if not supported

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[David Burns :automatedtester]

When sessions are created we need to check that if any of the capabilities passed in match that of gecko capabilites in Marionette-server

Comment 1

[David Burns :automatedtester]

https://tbpl.mozilla.org/?tree=Try&rev=0bfbca3c3528

Comment 2

[David Burns :automatedtester]

https://tbpl.mozilla.org/?tree=Try&rev=dc7d0afee49c

Comment 3

[Andreas Tolfsen ❲:ato❳]

I see the WebDriver spec has changed here.  Previously any unrecognised capabilities would be discarded.  Was there a decision in the WG to do this?

Comment 4

[David Burns :automatedtester]

(In reply to Andreas Tolfsen (:ato) from comment #3)
> I see the WebDriver spec has changed here.  Previously any unrecognised
> capabilities would be discarded.  Was there a decision in the WG to do this?

I used 2 vendors agreeing to make that as a decision. It has been in the mailing list for a while and at TPAC I am going to push for all decisions to be done async, if people dont read their email its their problem

Comment 5

[Andreas Tolfsen ❲:ato❳]

David, can you provide me with a link to the discussion?

Comment 6

[David Burns :automatedtester]

(In reply to Andreas Tolfsen (:ato) from comment #5)
> David, can you provide me with a link to the discussion?

http://lists.w3.org/Archives/Public/public-browser-tools-testing/2014OctDec/0000.html

Comment 7

[David Burns :automatedtester]

https://tbpl.mozilla.org/?tree=Try&rev=b22730327573

Comment 9

[David Burns :automatedtester]

This was discussed at http://www.w3.org/2014/10/30-testing-minutes.html#item08.

The resolution is to receive capabilities as 

{
  "desiredCapabilities": {},
  "requiredCapabilities": {}
}

Comment 10

[David Burns :automatedtester]

https://tbpl.mozilla.org/?tree=Try&rev=647bd6fa8817

Comment 11

[David Burns :automatedtester]

https://tbpl.mozilla.org/?tree=Try&rev=53c03fa816ef

Comment 12

[David Burns :automatedtester]

Attachment: MozReview Request: bz://1084125/AutomatedTester

/r/3581 - Bug 1084125: Merge in desired capabilities when passed in on new session; r=chmanchester
/r/3583 - Bug 1084125: Add in SessionNotCreatedException to marionette; r=chmanchester
/r/3585 - Bug 1084125: Allow requiredCapabilities in Marionette, if they are not fulfilled then a new session is not created; r=chmanchester

Pull down these commits:

hg pull review -r 30ae50686b26ea05f93752a74ce194199bace3ba

Comment 13

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8561372 [details]
MozReview Request: bz://1084125/AutomatedTester

https://reviewboard.mozilla.org/r/3579/#review2835

Ship It!

::: testing/marionette/marionette-server.js
(Diff revision 1)
> +          to = copy(from[key], to);

This copies each key in the object corresponding to "desiredCapabilities" to the top level of "to", and then below also copies that object over to the "desiredCapabilities" key in "to". This seems a little odd, but I guess per this comment it's required for backwards compatibility.

Comment 14

[David Burns :automatedtester]

https://hg.mozilla.org/integration/mozilla-inbound/rev/612eff467e8e
https://hg.mozilla.org/integration/mozilla-inbound/rev/9b48b7847f45
https://hg.mozilla.org/integration/mozilla-inbound/rev/78a06f2602a3

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/612eff467e8e
https://hg.mozilla.org/mozilla-central/rev/9b48b7847f45
https://hg.mozilla.org/mozilla-central/rev/78a06f2602a3

Comment 17

[David Burns :automatedtester]

Attachment: MozReview Request: Bug 1084125: Allow requiredCapabilities in Marionette, if they are not fulfilled then a new session is not created; r=chmanchester

Comment 18

[David Burns :automatedtester]

Attachment: MozReview Request: Bug 1084125: Merge in desired capabilities when passed in on new session; r=chmanchester

Comment 19

[David Burns :automatedtester]

Attachment: MozReview Request: Bug 1084125: Add in SessionNotCreatedException to marionette; r=chmanchester