Closed Bug 1084192 Opened 7 years ago Closed 7 years ago

JSHint fixes for apps/wallpaper

Categories

(Firefox OS Graveyard :: Gaia::Wallpaper, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: kgrandon, Assigned: ShellHacker)

Details

Attachments

(1 file)

Currently the following files need to be fixed: 

apps/wallpaper/js/pick.js
apps/wallpaper/js/share.js
apps/wallpaper/test/unit/pick_test.js
Sudheesh - would you want to give this bug a try?
Flags: needinfo?(sudheesh1995)
How about this ? |APP=wallpaper make hint| returns 0 errors. Requesting review
Flags: needinfo?(sudheesh1995)
Attachment #8506639 - Flags: review?(kgrandon)
Comment on attachment 8506639 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/25248

Forwarding to David who is the owner of the wallpaper app. Thank you for your contribution.
Attachment #8506639 - Flags: review?(kgrandon) → review?(dflanagan)
Comment on attachment 8506639 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/25248

Sudheesh,

Thanks for this! It looks great.

There were unrelated integration test failures, so I restarted those, but this is good to land once we get to green.
Attachment #8506639 - Flags: review?(dflanagan) → review+
David, the restarted test still seems pending to start, could you look into it ? I think the failures are unrelated and this is good for a checkin ?
I've gone ahead and landed this in master. Thanks for your patch!

https://github.com/mozilla-b2g/gaia/commit/ead2a8ee12066bc79403b91737a12f6322cff1ec
Assignee: nobody → sudheesh1995
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Kevin, I just noticed, that the pull request for this is still left open. I've just closed it.
You need to log in before you can comment on or make changes to this bug.