1084192 - JSHint fixes for apps/wallpaper

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Wallpaper, defect)

Description

[Kevin Grandon :kgrandon]

Currently the following files need to be fixed: 

apps/wallpaper/js/pick.js
apps/wallpaper/js/share.js
apps/wallpaper/test/unit/pick_test.js

Comment 1

[Kevin Grandon :kgrandon]

Sudheesh - would you want to give this bug a try?

Comment 2

[Sudheesh Singanamalla (:ShellHacker)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/25248

How about this ? |APP=wallpaper make hint| returns 0 errors. Requesting review

Comment 3

[Kevin Grandon :kgrandon]

Comment on attachment 8506639 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/25248

Forwarding to David who is the owner of the wallpaper app. Thank you for your contribution.

Comment 4

[David Flanagan [:djf]]

Comment on attachment 8506639 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/25248

Sudheesh,

Thanks for this! It looks great.

There were unrelated integration test failures, so I restarted those, but this is good to land once we get to green.

Comment 5

[Sudheesh Singanamalla (:ShellHacker)]

David, the restarted test still seems pending to start, could you look into it ? I think the failures are unrelated and this is good for a checkin ?

Comment 6

[Kevin Grandon :kgrandon]

I've gone ahead and landed this in master. Thanks for your patch!

https://github.com/mozilla-b2g/gaia/commit/ead2a8ee12066bc79403b91737a12f6322cff1ec

Comment 7

[Sudheesh Singanamalla (:ShellHacker)]

Kevin, I just noticed, that the pull request for this is still left open. I've just closed it.