Closed
Bug 1084322
Opened 10 years ago
Closed 10 years ago
Allow reftest analyzer to accept pasting of non-raw log output from treeherder
Categories
(Testing :: Reftest, defect)
Testing
Reftest
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla36
People
(Reporter: jwatt, Assigned: jwatt)
Details
Attachments
(1 file)
963 bytes,
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
Treeherder collapses the spaces between "REFTEST" and "IMAGE" in the lines: INFO - REFTEST IMAGE 1 (TEST): ...
Assignee | ||
Comment 1•10 years ago
|
||
Since I'm making the spaces optional, I've made the rest of the regexp a little more specific. Note that one space is removed by the: var match = line.match(/^.*?REFTEST (.*)$/); line, hence why we're dealing with two rather than three in this later regexp.
Attachment #8506815 -
Flags: review?(dbaron)
Comment on attachment 8506815 [details] [diff] [review] patch Now I learned about non-capturing parentheses. r=dbaron
Attachment #8506815 -
Flags: review?(dbaron) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8506815 [details] [diff] [review] patch https://hg.mozilla.org/integration/mozilla-inbound/rev/c567e39f19a0
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c567e39f19a0
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
This broke the display of failures of != tests, which just have "IMAGE:" with nothing between "IMAGE" and ":". I'll land the obvious patch as a followup.
You need to log in
before you can comment on or make changes to this bug.
Description
•