1084323 - Compilation issue with APZController

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[Maksim Lebedev]

User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:32.0) Gecko/20100101 Firefox/32.0
Build ID: 20140825202822

Steps to reproduce:

Compile m-c with ac_add_options --enable-metro


Actual results:

> 0:20.90 APZController.cpp
> 0:20.90 s:/FireFox/sourceNINE/widget/windows/winrt/APZController.cpp(150) : error C2562: 'mozilla::widget::winrt::APZController::RequestContentRepaint' : 'void' function returning a value
> 0:20.90         s:\firefox\sourcenine\widget\windows\winrt\APZController.h(39) : see declaration of 'mozilla::widget::winrt::APZController::RequestContentRepaint'
> 0:20.90 s:/FireFox/sourceNINE/widget/windows/winrt/APZController.cpp(161) : error C2562: 'mozilla::widget::winrt::APZController::RequestContentRepaint' : 'void' function returning a value
> 0:20.90         s:\firefox\sourcenine\widget\windows\winrt\APZController.h(39) : see declaration of 'mozilla::widget::winrt::APZController::RequestContentRepaint'


Expected results:

FireFox should be compiled correctly.

Comment 1

[Maksim Lebedev]

Attachment: issue_apzcontroller.diff

+ Changes: Repair compilation issue with APZController.cpp

Comment 2

[Maksim Lebedev]

IMHO: I think that we realy should keep possibility to build MetroFireFox in m-c. In other cases (in other branch) we can lost MetroFireFox very simply.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8506825 [details] [diff] [review]
issue_apzcontroller.diff

Review of attachment 8506825 [details] [diff] [review]:
-----------------------------------------------------------------

You *really* don't need 5 people to review a two-line compile fix. Specially when none of the people you're requesting had anything to do with introducing the problem.

Comment 4

[Maksim Lebedev]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #3)
> Specially when none of the people you're requesting had anything to do with introducing the problem.
I requested review from people, which were provided to me by Bugzilla system (I mean the helping line "suggested reviewers")

Comment 5

[Maksim Lebedev]

If nobody have objections, I put checkin flag.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

(In reply to Maksim Lebedev from comment #4)
> I requested review from people, which were provided to me by Bugzilla system
> (I mean the helping line "suggested reviewers")

That's a reasonable thing to do, but even so one or at most two reviewers is sufficient. Also you should know that the list of suggested reviewers is based entirely on the product/component the bug is filed in, so if the bug is in the wrong component then it will suggest the wrong reviewers. "Firefox/Untriaged" is not a good component to get reviewer suggestions from.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/b2g-inbound/rev/e1867db95493

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e1867db95493