Compilation issue with APZController

RESOLVED FIXED in mozilla36

Status

()

Core
Panning and Zooming
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Maksim Lebedev, Assigned: Maksim Lebedev)

Tracking

Trunk
mozilla36
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:32.0) Gecko/20100101 Firefox/32.0
Build ID: 20140825202822

Steps to reproduce:

Compile m-c with ac_add_options --enable-metro


Actual results:

> 0:20.90 APZController.cpp
> 0:20.90 s:/FireFox/sourceNINE/widget/windows/winrt/APZController.cpp(150) : error C2562: 'mozilla::widget::winrt::APZController::RequestContentRepaint' : 'void' function returning a value
> 0:20.90         s:\firefox\sourcenine\widget\windows\winrt\APZController.h(39) : see declaration of 'mozilla::widget::winrt::APZController::RequestContentRepaint'
> 0:20.90 s:/FireFox/sourceNINE/widget/windows/winrt/APZController.cpp(161) : error C2562: 'mozilla::widget::winrt::APZController::RequestContentRepaint' : 'void' function returning a value
> 0:20.90         s:\firefox\sourcenine\widget\windows\winrt\APZController.h(39) : see declaration of 'mozilla::widget::winrt::APZController::RequestContentRepaint'


Expected results:

FireFox should be compiled correctly.
(Assignee)

Updated

3 years ago
Blocks: 1042108
OS: Windows 8 → All
Hardware: x86_64 → All
(Assignee)

Comment 1

3 years ago
Created attachment 8506825 [details] [diff] [review]
issue_apzcontroller.diff

+ Changes: Repair compilation issue with APZController.cpp
Attachment #8506825 - Flags: review?(mbrubeck)
Attachment #8506825 - Flags: review?(mak77)
Attachment #8506825 - Flags: review?(jmathies)
Attachment #8506825 - Flags: review?(gavin.sharp)
Attachment #8506825 - Flags: review?(bugs)
Attachment #8506825 - Flags: feedback?
(Assignee)

Comment 2

3 years ago
IMHO: I think that we realy should keep possibility to build MetroFireFox in m-c. In other cases (in other branch) we can lost MetroFireFox very simply.
Comment on attachment 8506825 [details] [diff] [review]
issue_apzcontroller.diff

Review of attachment 8506825 [details] [diff] [review]:
-----------------------------------------------------------------

You *really* don't need 5 people to review a two-line compile fix. Specially when none of the people you're requesting had anything to do with introducing the problem.
Attachment #8506825 - Flags: review?(mbrubeck)
Attachment #8506825 - Flags: review?(mak77)
Attachment #8506825 - Flags: review?(jmathies)
Attachment #8506825 - Flags: review?(gavin.sharp)
Attachment #8506825 - Flags: review?(bugs)
Attachment #8506825 - Flags: review+
Attachment #8506825 - Flags: feedback?

Updated

3 years ago
Component: Untriaged → Build Config
Product: Firefox → Core
Component: Build Config → Panning and Zooming
(Assignee)

Comment 4

3 years ago
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #3)
> Specially when none of the people you're requesting had anything to do with introducing the problem.
I requested review from people, which were provided to me by Bugzilla system (I mean the helping line "suggested reviewers")
(Assignee)

Comment 5

3 years ago
If nobody have objections, I put checkin flag.
Keywords: checkin-needed
(In reply to Maksim Lebedev from comment #4)
> I requested review from people, which were provided to me by Bugzilla system
> (I mean the helping line "suggested reviewers")

That's a reasonable thing to do, but even so one or at most two reviewers is sufficient. Also you should know that the list of suggested reviewers is based entirely on the product/component the bug is filed in, so if the bug is in the wrong component then it will suggest the wrong reviewers. "Firefox/Untriaged" is not a good component to get reviewer suggestions from.
https://hg.mozilla.org/integration/b2g-inbound/rev/e1867db95493
Blocks: 1074401
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e1867db95493
Assignee: nobody → alessarik
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.