Closed
Bug 1084419
Opened 10 years ago
Closed 10 years ago
Share button tooltip shouldn't use title capitalization
Categories
(Firefox :: Toolbars and Customization, defect)
Firefox
Toolbars and Customization
Tracking
()
RESOLVED
FIXED
Firefox 36
People
(Reporter: dao, Assigned: marc.bizal, Mentored)
References
Details
(Whiteboard: [good first bug])
Attachments
(1 file, 1 obsolete file)
1.23 KB,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
The Share button tooltip reads "Share This Page". Tooltips shouldn't use title capitalization, i.e. this one should read "Share this page" instead.
This needs to be fixed here (social-share-button.tooltiptext):
http://hg.mozilla.org/mozilla-central/annotate/cc7fc5918561/browser/locales/en-US/chrome/browser/customizableui/customizableWidgets.properties#l106
Assignee | ||
Comment 1•10 years ago
|
||
Updated•10 years ago
|
Attachment #8507564 -
Flags: review?(dao)
Reporter | ||
Comment 2•10 years ago
|
||
Comment on attachment 8507564 [details] [diff] [review]
Fixed social share label and tooltip capitalization.
Marcus, thanks for the patch. social-share-button.label should actually use title capitalization, only social-share-button.tooltiptext should not.
Attachment #8507564 -
Flags: review?(dao) → review-
Assignee | ||
Comment 3•10 years ago
|
||
Fixed. Sorry! Thanks for your patience on my first patch.
Attachment #8508339 -
Flags: review?(dao)
Assignee | ||
Updated•10 years ago
|
Attachment #8508339 -
Attachment description: socialshare-capital.patch → Fixed patch.
Reporter | ||
Comment 4•10 years ago
|
||
Comment on attachment 8508339 [details] [diff] [review]
Fixed patch.
Thanks!
Attachment #8508339 -
Flags: review?(dao) → review+
Reporter | ||
Updated•10 years ago
|
Attachment #8507564 -
Attachment is obsolete: true
Reporter | ||
Comment 5•10 years ago
|
||
Assignee: nobody → marc.bizal
Comment 6•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Reporter | ||
Comment 7•10 years ago
|
||
Marcus, I filed bug 1088257 as a followup, maybe you're interested in that as well.
You need to log in
before you can comment on or make changes to this bug.
Description
•