Share button tooltip shouldn't use title capitalization

RESOLVED FIXED in Firefox 36

Status

()

Firefox
Toolbars and Customization
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: dao, Assigned: Marcus Bizal, Mentored)

Tracking

Trunk
Firefox 36
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

4 years ago
The Share button tooltip reads "Share This Page". Tooltips shouldn't use title capitalization, i.e. this one should read "Share this page" instead.

This needs to be fixed here (social-share-button.tooltiptext):
http://hg.mozilla.org/mozilla-central/annotate/cc7fc5918561/browser/locales/en-US/chrome/browser/customizableui/customizableWidgets.properties#l106
(Assignee)

Comment 1

4 years ago
Created attachment 8507564 [details] [diff] [review]
Fixed social share label and tooltip capitalization.
(Reporter)

Comment 2

4 years ago
Comment on attachment 8507564 [details] [diff] [review]
Fixed social share label and tooltip capitalization.

Marcus, thanks for the patch. social-share-button.label should actually use title capitalization, only social-share-button.tooltiptext should not.
Attachment #8507564 - Flags: review?(dao) → review-
(Assignee)

Comment 3

4 years ago
Created attachment 8508339 [details] [diff] [review]
Fixed patch.

Fixed. Sorry! Thanks for your patience on my first patch.
Attachment #8508339 - Flags: review?(dao)
(Assignee)

Updated

4 years ago
Attachment #8508339 - Attachment description: socialshare-capital.patch → Fixed patch.
(Reporter)

Comment 4

4 years ago
Comment on attachment 8508339 [details] [diff] [review]
Fixed patch.

Thanks!
Attachment #8508339 - Flags: review?(dao) → review+
(Reporter)

Updated

4 years ago
Attachment #8507564 - Attachment is obsolete: true
(Reporter)

Comment 5

4 years ago
https://hg.mozilla.org/integration/fx-team/rev/fdcc2e34706c
Assignee: nobody → marc.bizal
https://hg.mozilla.org/mozilla-central/rev/fdcc2e34706c
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
(Reporter)

Updated

4 years ago
Blocks: 1088257
(Reporter)

Comment 7

4 years ago
Marcus, I filed bug 1088257 as a followup, maybe you're interested in that as well.
You need to log in before you can comment on or make changes to this bug.