Closed Bug 1084423 Opened 5 years ago Closed 5 years ago

Stumbler: list of scanned wifis needs proper size limit

Categories

(Android Background Services Graveyard :: Geolocation, defect)

Firefox 35
All
Android
defect
Not set

Tracking

(firefox35 fixed, firefox36 fixed, fennec35+)

RESOLVED FIXED
Firefox 36
Tracking Status
firefox35 --- fixed
firefox36 --- fixed
fennec 35+ ---

People

(Reporter: garvan, Assigned: garvan)

Details

Attachments

(1 file)

In MozStumbler testing, we discovered a bug with the size limit on wifi scans. 
This can result in excessively large collections for a single location. The existing guard is faulty as it checks the guards before converting the scanned information array to JSON. The scanned info array is where there should be a size limit.

The equivalent PR in MozStumbler
https://github.com/mozilla/MozStumbler/pull/1004
This is the fix from MozStumbler, ported to Fennec's stumbler service. It guards the cell and wifi list from exceeding a fixed size.
Attachment #8507000 - Flags: review?(vng)
Assignee: nobody → gkeeley
Status: NEW → ASSIGNED
tracking-fennec: --- → 35+
Attachment #8507000 - Flags: approval-mozilla-aurora?
Approval Request Comment
[Feature/regressing bug #]: Related to Fennec stumbler (big 1038843), this is a buffer size guard that was missed. The bug was found in MozStumbler (which is the host project for this library used in Fennec): https://github.com/mozilla/MozStumbler/pull/1004
[User impact if declined]: Potential to consume excessive memory as buffer is allowed to grow too large.
[Describe test coverage new/current, TBPL]: Comment #2 describes the tests that happen in MozStumbler for this case.
[Risks and why]: Excessive memory consumption.
[String/UUID change made/needed]: None
https://hg.mozilla.org/mozilla-central/rev/e91747e0ee2f
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 36
Attachment #8507000 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Flags: qe-verify-
Flags: in-testsuite?
You need to log in before you can comment on or make changes to this bug.