Closed
Bug 1084423
Opened 10 years ago
Closed 10 years ago
Stumbler: list of scanned wifis needs proper size limit
Categories
(Android Background Services Graveyard :: Geolocation, defect)
Tracking
(firefox35 fixed, firefox36 fixed, fennec35+)
RESOLVED
FIXED
Firefox 36
People
(Reporter: garvan, Assigned: garvan)
Details
Attachments
(1 file)
2.43 KB,
patch
|
vng
:
review+
lsblakk
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
In MozStumbler testing, we discovered a bug with the size limit on wifi scans. This can result in excessively large collections for a single location. The existing guard is faulty as it checks the guards before converting the scanned information array to JSON. The scanned info array is where there should be a size limit. The equivalent PR in MozStumbler https://github.com/mozilla/MozStumbler/pull/1004
This is the fix from MozStumbler, ported to Fennec's stumbler service. It guards the cell and wifi list from exceeding a fixed size.
Attachment #8507000 -
Flags: review?(vng)
Updated•10 years ago
|
Assignee: nobody → gkeeley
Status: NEW → ASSIGNED
tracking-fennec: --- → 35+
Comment 2•10 years ago
|
||
Comment on attachment 8507000 [details] [diff] [review] stumbler-wifi-count-guard-fix.patch Review of attachment 8507000 [details] [diff] [review]: ----------------------------------------------------------------- This looks ok to me. The relevant unit tests in MozStumbler that exercise this patch are here: https://github.com/mozilla/MozStumbler/blob/3c208dd90cbf8329ea3de711acec6d63d1d901d7/android/src/test/java/org/mozilla/mozstumbler/service/stumblerthread/datahandling/DataStorageManagerTest.java#L60 and here: https://github.com/mozilla/MozStumbler/blob/3c208dd90cbf8329ea3de711acec6d63d1d901d7/android/src/test/java/org/mozilla/mozstumbler/service/stumblerthread/datahandling/DataStorageManagerTest.java#L81
Attachment #8507000 -
Flags: review?(vng) → review+
Try green: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=470b7d6a8c5b
Keywords: checkin-needed
Attachment #8507000 -
Flags: approval-mozilla-aurora?
https://hg.mozilla.org/integration/fx-team/rev/e91747e0ee2f
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Approval Request Comment [Feature/regressing bug #]: Related to Fennec stumbler (big 1038843), this is a buffer size guard that was missed. The bug was found in MozStumbler (which is the host project for this library used in Fennec): https://github.com/mozilla/MozStumbler/pull/1004 [User impact if declined]: Potential to consume excessive memory as buffer is allowed to grow too large. [Describe test coverage new/current, TBPL]: Comment #2 describes the tests that happen in MozStumbler for this case. [Risks and why]: Excessive memory consumption. [String/UUID change made/needed]: None
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e91747e0ee2f
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 36
Updated•10 years ago
|
status-firefox35:
--- → affected
status-firefox36:
--- → fixed
Updated•10 years ago
|
Attachment #8507000 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment hidden (spam) |
You need to log in
before you can comment on or make changes to this bug.
Description
•