Stumbler: list of scanned wifis needs proper size limit

RESOLVED FIXED in Firefox 35

Status

Android Background Services
Geolocation
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: garvan, Assigned: garvan)

Tracking

Firefox 35
Firefox 36
All
Android
Bug Flags:
in-testsuite ?
qe-verify -

Firefox Tracking Flags

(firefox35 fixed, firefox36 fixed, fennec35+)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
In MozStumbler testing, we discovered a bug with the size limit on wifi scans. 
This can result in excessively large collections for a single location. The existing guard is faulty as it checks the guards before converting the scanned information array to JSON. The scanned info array is where there should be a size limit.

The equivalent PR in MozStumbler
https://github.com/mozilla/MozStumbler/pull/1004
(Assignee)

Comment 1

4 years ago
Created attachment 8507000 [details] [diff] [review]
stumbler-wifi-count-guard-fix.patch

This is the fix from MozStumbler, ported to Fennec's stumbler service. It guards the cell and wifi list from exceeding a fixed size.
Attachment #8507000 - Flags: review?(vng)
Assignee: nobody → gkeeley
Status: NEW → ASSIGNED
tracking-fennec: --- → 35+
(Assignee)

Comment 3

4 years ago
Try green:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=470b7d6a8c5b
Keywords: checkin-needed
(Assignee)

Updated

4 years ago
Attachment #8507000 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/integration/fx-team/rev/e91747e0ee2f
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
(Assignee)

Comment 5

4 years ago
Approval Request Comment
[Feature/regressing bug #]: Related to Fennec stumbler (big 1038843), this is a buffer size guard that was missed. The bug was found in MozStumbler (which is the host project for this library used in Fennec): https://github.com/mozilla/MozStumbler/pull/1004
[User impact if declined]: Potential to consume excessive memory as buffer is allowed to grow too large.
[Describe test coverage new/current, TBPL]: Comment #2 describes the tests that happen in MozStumbler for this case.
[Risks and why]: Excessive memory consumption.
[String/UUID change made/needed]: None
https://hg.mozilla.org/mozilla-central/rev/e91747e0ee2f
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 36
status-firefox35: --- → affected
status-firefox36: --- → fixed
Attachment #8507000 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment hidden (spam)
Flags: qe-verify-
Flags: in-testsuite?
You need to log in before you can comment on or make changes to this bug.