1084472 - After signing into FxA, asked to reconnect to sync after restart

Status: RESOLVED DUPLICATE of bug 1124553

(Firefox :: Sync, defect)

Description

[Edwin Wong [:edwong]]

Attachment: error-1413563551367.txt

1. in Fx34 beta, sign into sync
2. restart browser
3. click hamburger menu

actual: the text on the bottom of drop down says: 'Reconnect to sync...'

Comment 1

[Edwin Wong [:edwong]]

:pdehaan is unable to repro on his fx34 beta

Comment 2

[Chris Karlof [:ckarlof]]

Hmmm. Edwin, we may want to look at your profile, in particular, what the entry looks like in your password manager.

Comment 3

[Chris Karlof [:ckarlof]]

Mark, I'm not sure if you're cc'ed, but there might be some bug in how creds are transferred into the password manager.

Comment 4

[Mark Hammond [:markh] [:mhammond]]

We do know that you can get into this state if you never unlock the master-password during the session when the data is migrated.  Similarly, if you ever do get into a state where reauth is necessary and decline to unlock the new credentials also wont be saved back.

I see in the log lots of:

1413563546315	FirefoxAccounts	ERROR	Failed to save data to the login manager: [Exception... "User canceled master password entry"  nsresult: "0x80004004 (NS_ERROR_ABORT)"  location: "JS frame :: resource://gre/components/crypto-SDR.js :: LoginManagerCrypto_SDR.prototype.encrypt :: line 115"  data: no] Stack trace: LoginManagerCrypto_SDR.prototype.encrypt()@resource://gre/components/crypto-SDR.js:115 < 

So Edwin, 2 questions:

* Are you constantly declining to unlock the MP during this process?  If so, what are you expecting to happen?
* Can you reproduce this reliably after you *do* unlock, or does it only happen when you decline?

Comment 5

[Edwin Wong [:edwong]]

I've never used MP with this profile.  Currently I have no passwords saved and MP is uncheck or not in use:
http://people.mozilla.org/~ewong2/mp.png

I tried enabling MP, restart, then disable and my browser still says 'reconnect to sync...'

Comment 6

[Mark Hammond [:markh] [:mhammond]]

I think we can treat this as a dupe of bug 1124553 rather than depending on it.