Closed Bug 1084545 Opened 5 years ago Closed 5 years ago

Update nav button stroke color

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 36
Tracking Status
firefox34 --- unaffected
firefox35 --- fixed
firefox36 --- fixed

People

(Reporter: mcomella, Assigned: mcomella)

References

Details

Attachments

(2 files)

via bug 1077730 comment 8:

> Unrelated: is the stroke on the back button #5F6368 ?

For private browsing. #BF for normal browsing (via IRC).

Depends on bug 1084542 to avoid annoying rebases, though we may need a separate patch to uplift if uplift is necessary.
For aurora.
Attachment #8507151 - Flags: review?(lucasr.at.mozilla)
Comment on attachment 8507142 [details] [diff] [review]
Update nav button stroke colors

Review of attachment 8507142 [details] [diff] [review]:
-----------------------------------------------------------------

Ok.
Attachment #8507142 - Flags: review?(lucasr.at.mozilla) → review+
Comment on attachment 8507151 [details] [diff] [review]
Update nav button stroke colors (aurora)

Review of attachment 8507151 [details] [diff] [review]:
-----------------------------------------------------------------

Good.
Attachment #8507151 - Flags: review?(lucasr.at.mozilla) → review+
Comment on attachment 8507151 [details] [diff] [review]
Update nav button stroke colors (aurora)

Approval Request Comment
[Feature/regressing bug #]:
  We added new assets to sharpen the appearance of the url bar on tablet, but apparently the colors were slightly different - this patch updates the places in the code where we draw icons with the appropriate colors.

[User impact if declined]:
  Users will have an inconsistent UI experience: the border of the navigation buttons (forward/back) will be a different color from the URL bar

[Describe test coverage new/current, TBPL]: None

[Risks and why]: 
  Low - we're swapping out some set color methods. In the worst case, we get the color wrong.
 
[String/UUID change made/needed]: None
Attachment #8507151 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/2123184ca578
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Attachment #8507151 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.