1084545 - Update nav button stroke color

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

via bug 1077730 comment 8:

> Unrelated: is the stroke on the back button #5F6368 ?

For private browsing. #BF for normal browsing (via IRC).

Depends on bug 1084542 to avoid annoying rebases, though we may need a separate patch to uplift if uplift is necessary.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

Attachment: Update nav button stroke colors

Comment 2

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

Confirmed that this does need to be uplfited for aurora: the new tablet toolbar assets present in central [1] and aurora [2], but not present in beta [3].

[1]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/drawable-large-xhdpi-v11/url_bar_entry_default.9.png
[2]: https://mxr.mozilla.org/mozilla-aurora/source/mobile/android/base/resources/drawable-large-xhdpi-v11/url_bar_entry_default.9.png
[3]: https://mxr.mozilla.org/mozilla-beta/source/mobile/android/base/resources/drawable-large-xhdpi-v11/url_bar_entry_default.9.png

Comment 3

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

Attachment: Update nav button stroke colors (aurora)

For aurora.

Comment 4

[Lucas Rocha (:lucasr)]

Comment on attachment 8507142 [details] [diff] [review]
Update nav button stroke colors

Review of attachment 8507142 [details] [diff] [review]:
-----------------------------------------------------------------

Ok.

Comment 5

[Lucas Rocha (:lucasr)]

Comment on attachment 8507151 [details] [diff] [review]
Update nav button stroke colors (aurora)

Review of attachment 8507151 [details] [diff] [review]:
-----------------------------------------------------------------

Good.

Comment 6

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

Comment on attachment 8507151 [details] [diff] [review]
Update nav button stroke colors (aurora)

Approval Request Comment
[Feature/regressing bug #]:
  We added new assets to sharpen the appearance of the url bar on tablet, but apparently the colors were slightly different - this patch updates the places in the code where we draw icons with the appropriate colors.

[User impact if declined]:
  Users will have an inconsistent UI experience: the border of the navigation buttons (forward/back) will be a different color from the URL bar

[Describe test coverage new/current, TBPL]: None

[Risks and why]: 
  Low - we're swapping out some set color methods. In the worst case, we get the color wrong.
 
[String/UUID change made/needed]: None

Comment 7

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/2123184ca578

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2123184ca578

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/aea9af58f4d4