Closed Bug 1084607 Opened 5 years ago Closed 5 years ago

SurfaceTextureImage not declared in GLImages.ccp

Categories

(Core :: Graphics: Layers, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED INVALID

People

(Reporter: rillian, Assigned: snorp)

References

Details

Attachments

(1 file)

Problem with unified build:

/builds/slave/m-in-and-nu-000000000000000000/build/gfx/layers/GLImages.cpp:19:1: error: 'SurfaceTextureImage' has not been declared
I get other errors locally.

 0:08.54 In file included from /home/giles/mozilla/firefox/gfx/layers/client/CanvasClient.cpp:21:0:
 0:08.54 ../../dist/include/mozilla/layers/TextureClientOGL.h:77:24: error: 'AndroidSurfaceTexture' has not been declared
 0:08.54                         AndroidSurfaceTexture* aSurfTex,
Also fixes another AndroidSurfaceTexture issue.
Assignee: nobody → giles
Attachment #8507206 - Flags: review?(jgilbert)
Comment on attachment 8507206 [details] [diff] [review]
Add missing namespace references.

Review of attachment 8507206 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/GLImages.cpp
@@ +13,2 @@
>  using namespace mozilla::gl;
> +using namespace mozilla::layers;

FWIW, using `using` tends to cause more unified build problems in the future.
Attachment #8507206 - Flags: review?(jgilbert) → review+
Would you prefer prefixes instead?
(In reply to Ralph Giles (:rillian) from comment #6)
> Would you prefer prefixes instead?

Prefixes are better for unified builds, since they don't leak across (what would normally be) TUs.
I had to back out bug 1014614 for bustage, and this was getting in my way, so it's backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/34f6b30b6dfa
James, can I leave these fixes to you now that time pressure is off? Let me know if you want any help or testing?
Assignee: giles → snorp
Yeah I fixed this in the relanding. Thanks!
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.