1084970 - Windows build bustage: Error: im\installer\package-manifest:35: Missing file(s): bin/gkmedias.dll

Status: RESOLVED FIXED

(Instantbird Graveyard :: Other, defect)

Description

[Patrick Cloke [:clokep]]

Bug 942043 busted us by changing when gkmedia.dll is included in Windows builds. It now seems to be linked into xul.dll by default.

Comment 1

[Patrick Cloke [:clokep]]

Well, bug 942043 contains the FIX, but the actual bustage is from bug 922912.

Comment 2

[Patrick Cloke [:clokep]]

Attachment: Port changes to im, mail, and suite

Comment 3

[Florian Quèze [:florian]]

Comment on attachment 8507365 [details] [diff] [review]
Port changes to im, mail, and suite

The im/ and mail/ part aren't correct, we still need to package the msvc*.dll files ifdef XP_WIN32

Comment 4

[Edmund Wong (:ewong)]

Comment on attachment 8507365 [details] [diff] [review]
Port changes to im, mail, and suite

Looks good..  fb+, will wait for Callek's review

Comment 5

[Patrick Cloke [:clokep]]

Attachment: Port changes to im, mail, and suite v2

This fixes the if-defs properly.

Comment 6

[aleth [:aleth]]

Comment on attachment 8507367 [details] [diff] [review]
Port changes to im, mail, and suite v2

Review of attachment 8507367 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! Needs another r+ from a /mail peer.

Comment 7

[Justin Wood (:Callek)]

Comment on attachment 8507367 [details] [diff] [review]
Port changes to im, mail, and suite v2

Review of attachment 8507367 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not an im\ reviewer, but f+

Comment 8

[Patrick Cloke [:clokep]]

Justin, I was hoping you could review the suite part, actually. But I'm going to check this in as a=bustage-fix, it's a trivial change.

Comment 9

[Patrick Cloke [:clokep]]

https://hg.mozilla.org/comm-central/rev/69c23a8ea91d

Comment 10

[Justin Wood (:Callek)]

O missed that there was a suite part. Sorry