1085004 - mIsCachable is always true

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Kent James (:rkent)]

mIsCachable in nsMsgDBFolder seems to always be true. Should we remove it? It would be good to look through code history to confirm that it used to be used, but the original use was removed.

Comment 1

[:aceman]

'hg grep --all mIsCachable' only returned this:
mailnews/base/util/nsMsgDBFolder.cpp:9082:-:  mIsCachable(PR_TRUE),
mailnews/base/util/nsMsgDBFolder.cpp:9082:-:      mIsCachable = PR_TRUE;
mailnews/base/util/nsMsgDBFolder.cpp:9082:+:  mIsCachable(true),
mailnews/base/util/nsMsgDBFolder.cpp:9082:+:      mIsCachable = true;
mailnews/base/util/nsMsgDBFolder.h:8587:-:  PRBool mIsCachable;
mailnews/base/util/nsMsgDBFolder.h:8587:+:  bool mIsCachable;
mailnews/base/util/nsMsgDBFolder.cpp:0:+:  mIsCachable(PR_TRUE),
mailnews/base/util/nsMsgDBFolder.cpp:0:+:      mIsCachable = PR_TRUE;
mailnews/base/util/nsMsgDBFolder.h:0:+:  PRBool mIsCachable;

So it looks it was never used as far as hg history can see.

Comment 2

[:aceman]

Thomas, would you like to try your new patching skills on this easy one? :)

Comment 3

[Thomas D. (:thomas8)]

Attachment: 1085004.remove_mIsCachable.patch

(In reply to :aceman from comment #2)
> Thomas, would you like to try your new patching skills on this easy one? :)

Sure. Here's the patch :)

Yes, mIsCachable looks obsolete when it's always true and never queried.

I picked a reviewer from suggestions; pls change as required.

Comment 4

[:aceman]

Comment on attachment 8512566 [details] [diff] [review]
1085004.remove_mIsCachable.patch

Review of attachment 8512566 [details] [diff] [review]:
-----------------------------------------------------------------

I think Bienvenu is inactive so we do not ask him for review these days. Let's try irving.

Comment 5

[:Irving Reid (No longer working on Firefox)]

Comment on attachment 8512566 [details] [diff] [review]
1085004.remove_mIsCachable.patch

Review of attachment 8512566 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the long delayed review; I'm not as active with Mozilla these days so I'm not getting around to things as quickly.

Comment 6

[Patrick Cloke [:clokep]]

https://hg.mozilla.org/comm-central/rev/627a6217ac9c