1085022 - XMPP fails to handle server-to-server communication errors

Status: RESOLVED FIXED

(Chat Core :: XMPP, defect)

Description

[aleth [:aleth]]

For example, for a gmail.com contact (via syndication) with a ch3kr.net account:

onTransportStatus(STATUS_RECEIVING_FROM)
[18/10/2014 16:57:02] LOG   (@ prpl-jabber: XMPPParser.prototype._logReceivedData resource:///modules/xmpp-xml.jsm:320)
received:
<presence xmlns="jabber:client" type="error" to="[e-mail]" from="[e-mail]">
 <error xmlns="jabber:client" type="cancel">
  <remote-server-not-found xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"/>
  <text xmlns="urn:ietf:params:xml:ns:xmpp-stanzas">
   Server-to-server connection failed: Encrypted server-to-server communication is required but was not offered
  </text>
 </error>
</presence>

[18/10/2014 16:57:02] DEBUG (@ prpl-jabber: XMPPAccountPrototype.onPresenceStanza resource:///modules/xmpp.jsm:909)

Received presence stanza for [e-mail]
[18/10/2014 16:57:10] LOG   (@ prpl-jabber: Socket.sendString resource:///modules/socket.jsm:255)
Sending:
<message to="[e-mail]" type="chat" id="10"><body>testing</body></message>
[18/10/2014 16:57:10] DEBUG (@ prpl-jabber: Socket.onTransportStatus resource:///modules/socket.jsm:557)
onTransportStatus(STATUS_SENDING_TO)
[18/10/2014 16:57:12] DEBUG (@ prpl-jabber: Socket.onTransportStatus resource:///modules/socket.jsm:557)
onTransportStatus(STATUS_RECEIVING_FROM)
[18/10/2014 16:57:12] LOG   (@ prpl-jabber: XMPPParser.prototype._logReceivedData resource:///modules/xmpp-xml.jsm:320)
received:
<message xmlns="jabber:client" id="10" type="error" to="[e-mail]/Instantbird" from="[e-mail]">
 <error xmlns="jabber:client" type="cancel">
  <remote-server-not-found xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"/>
  <text xmlns="urn:ietf:params:xml:ns:xmpp-stanzas">
   Server-to-server connection failed: Encrypted server-to-server communication is required but was not offered
  </text>
 </error>
</message>

We can't do anything with such a contact, but the prpl will happily open conversations and appear to send messages without visible error messages.

Comment 1

[Florian Quèze [:florian]]

(In reply to aleth [:aleth] from comment #0)

> the prpl will happily open conversations

This seems a reasonable behavior (as the s2s problem could be temporary).

> and appear to send messages without visible error messages.

Are we currently not handling <message type="error"> at all?

Comment 2

[aleth [:aleth]]

(In reply to Florian Quèze [:florian] [:flo] from comment #1)
> (In reply to aleth [:aleth] from comment #0)
> 
> > the prpl will happily open conversations
> 
> This seems a reasonable behavior (as the s2s problem could be temporary).

A <presence type="error"> stanza should lead to the contact being status=unknown, so I disagree.

Comment 3

[aleth [:aleth]]

Attachment: handleerrors.diff

This improves things a bit.

Comment 4

[aleth [:aleth]]

Attachment: handleerrors.diff v2

This is a little less lazy.

Comment 5

[aleth [:aleth]]

Attachment: handleerrors.diff v3

Avoid unrelated whitespace changes. Sorry for the bugspam

Comment 6

[aleth [:aleth]]

Attachment: handleerrors.diff v4

Put back early return for errors to avoid typing notifications, as discussed on IRC.

Comment 7

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/06ccfbaeffcd