1085160 - Port the code that uses nsRenderingContext::IntersectClip() to Moz2D

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8507551 [details] [diff] [review]
patch

Review of attachment 8507551 [details] [diff] [review]:
-----------------------------------------------------------------

The nsRenderingContext code snapped the clip to device pixels when possible, why don't we do that any more?

Comment 3

[Jonathan Watt [:jwatt]]

We still snap. The variant of NSRectToRect() that takes the third DrawTarget argument uses that argument to snap to its device context.

Comment 4

[Jonathan Watt [:jwatt]]

To its device *pixels*, I mean. (And using the same snapping strategy as the nsRenderingContext code that it replaces.)

Comment 5

[Matt Woodrow (:mattwoodrow)]

Ok. That's not very obvious from the callsites, though I guess the nsRenderingContext one wasn't either!

Comment 6

[Jonathan Watt [:jwatt]]

Comment on attachment 8507551 [details] [diff] [review]
patch

https://hg.mozilla.org/integration/mozilla-inbound/rev/6d835b966b97

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6d835b966b97