Port the code that uses nsRenderingContext::IntersectClip() to Moz2D

RESOLVED FIXED in mozilla36

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

Trunk
mozilla36
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

No description provided.
Posted patch patchSplinter Review
Attachment #8507551 - Flags: review?(matt.woodrow)
Comment on attachment 8507551 [details] [diff] [review]
patch

Review of attachment 8507551 [details] [diff] [review]:
-----------------------------------------------------------------

The nsRenderingContext code snapped the clip to device pixels when possible, why don't we do that any more?
We still snap. The variant of NSRectToRect() that takes the third DrawTarget argument uses that argument to snap to its device context.
To its device *pixels*, I mean. (And using the same snapping strategy as the nsRenderingContext code that it replaces.)
Ok. That's not very obvious from the callsites, though I guess the nsRenderingContext one wasn't either!
Attachment #8507551 - Flags: review?(matt.woodrow) → review+
https://hg.mozilla.org/mozilla-central/rev/6d835b966b97
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Blocks: 1087958
You need to log in before you can comment on or make changes to this bug.