Closed Bug 1085160 Opened 6 years ago Closed 6 years ago

Port the code that uses nsRenderingContext::IntersectClip() to Moz2D

Categories

(Core :: Graphics, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: jwatt, Assigned: jwatt)

References

Details

Attachments

(1 file)

No description provided.
Attached patch patchSplinter Review
Attachment #8507551 - Flags: review?(matt.woodrow)
Comment on attachment 8507551 [details] [diff] [review]
patch

Review of attachment 8507551 [details] [diff] [review]:
-----------------------------------------------------------------

The nsRenderingContext code snapped the clip to device pixels when possible, why don't we do that any more?
We still snap. The variant of NSRectToRect() that takes the third DrawTarget argument uses that argument to snap to its device context.
To its device *pixels*, I mean. (And using the same snapping strategy as the nsRenderingContext code that it replaces.)
Ok. That's not very obvious from the callsites, though I guess the nsRenderingContext one wasn't either!
Attachment #8507551 - Flags: review?(matt.woodrow) → review+
https://hg.mozilla.org/mozilla-central/rev/6d835b966b97
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.