Closed
Bug 1085160
Opened 9 years ago
Closed 9 years ago
Port the code that uses nsRenderingContext::IntersectClip() to Moz2D
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: jwatt, Assigned: jwatt)
References
Details
Attachments
(1 file)
28.55 KB,
patch
|
mattwoodrow
:
review+
jwatt
:
checkin+
|
Details | Diff | Splinter Review |
No description provided.
![]() |
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8507551 -
Flags: review?(matt.woodrow)
Comment 2•9 years ago
|
||
Comment on attachment 8507551 [details] [diff] [review] patch Review of attachment 8507551 [details] [diff] [review]: ----------------------------------------------------------------- The nsRenderingContext code snapped the clip to device pixels when possible, why don't we do that any more?
![]() |
Assignee | |
Comment 3•9 years ago
|
||
We still snap. The variant of NSRectToRect() that takes the third DrawTarget argument uses that argument to snap to its device context.
![]() |
Assignee | |
Comment 4•9 years ago
|
||
To its device *pixels*, I mean. (And using the same snapping strategy as the nsRenderingContext code that it replaces.)
Comment 5•9 years ago
|
||
Ok. That's not very obvious from the callsites, though I guess the nsRenderingContext one wasn't either!
Updated•9 years ago
|
Attachment #8507551 -
Flags: review?(matt.woodrow) → review+
![]() |
Assignee | |
Comment 6•9 years ago
|
||
Comment on attachment 8507551 [details] [diff] [review] patch https://hg.mozilla.org/integration/mozilla-inbound/rev/6d835b966b97
Attachment #8507551 -
Flags: checkin+
https://hg.mozilla.org/mozilla-central/rev/6d835b966b97
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•