[EME] Set timeout on async GMP shutdown in non xpcom-shutdown case

RESOLVED FIXED in Firefox 37

Status

()

Core
Audio/Video
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: cpearce, Assigned: cpearce)

Tracking

(Blocks: 1 bug)

Trunk
mozilla36
x86_64
Windows Vista
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox37 fixed, firefox38 fixed, firefox39 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
We allow GMPs to shutdown asynchronously, but we only actually set a timeout on shut if we're shutting down in XPCOM shutdown. We should also set a timeout if we're shutting down in the normal plugin shutdown case too.
(Assignee)

Updated

4 years ago
Assignee: nobody → cpearce
(Assignee)

Comment 1

4 years ago
Created attachment 8508550 [details] [diff] [review]
Patch: Move GMPAsyncShutdown timeout into GMPParent class

Move the GMPAsyncShutdown timeout into the GMPParent class, so that if we do async shutdown in the non-xpcom shutdown case, we still have a timeout.

I hit this case while writing unit tests in but 1055395.
Attachment #8508550 - Flags: review?(rjesup)

Updated

4 years ago
Attachment #8508550 - Flags: review?(rjesup) → review+
https://hg.mozilla.org/mozilla-central/rev/1a7fc6ba2aa7
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
(Assignee)

Comment 4

3 years ago
Mass update firefox-status to track EME uplift.
status-firefox37: --- → fixed
status-firefox38: --- → fixed
status-firefox39: --- → fixed
You need to log in before you can comment on or make changes to this bug.