1085270 - Remove custom protocol handler for Youtube

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Martijn Wargers (dead)]

See bug 777633.
Basically, a backout of https://bug777633.bugzilla.mozilla.org/attachment.cgi?id=660562 is needed.

The Youtube site is working correctly in the browser, the video is played inside the browser now. So the custom protocol handler that was meant to be invoked doesn't do anything useful anymore, so should be removed.

Comment 1

[Martijn Wargers (dead)]

Attachment: youtube.diff

I still wonder why this didn't work for Youtube and why I can't couldn't get the vnd.youtube: protocol to work with this protocol handler: http://people.mozilla.org/~mwargers/tests/dom/protocol/protocol_in_frame.html

But anyway, this has to be removed, as it is not needed anymore.
Does this need to go through tryserver?

Comment 2

[[:fabrice] Fabrice Desré]

Comment on attachment 8509545 [details] [diff] [review]
youtube.diff

Review of attachment 8509545 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Martijn!

Comment 3

[Martijn Wargers (dead)]

I asked fabrice on irc if this would need to go through try. This was his response:
00:59 fabrice: mwargers: I don't think try will tell you anything, we have no tests for that

I agree with that. I just wouldn't know what try run to trigger for this.
The gaia-ui-test test_browser_play_youtube_video.py should normally cover this, but Youtube has made their site so that it's playing videos in the browser, it appears.

So I'm just adding the 'checkin-needed' keyword for this. Let me know if you disagree.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/8c1573307204

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8c1573307204