Closed Bug 1085276 Opened 5 years ago Closed 5 years ago

[Messages] Error in sms_test when running with a newer mocha

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(b2g-v2.2 fixed)

RESOLVED FIXED
2.1 S9 (21Nov)
Tracking Status
b2g-v2.2 --- fixed

People

(Reporter: julienw, Assigned: julienw)

References

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
steveck
: review+
Details | Review
14:18:18 INFO - TEST-UNEXPECTED-FAIL | sms/test/unit/sms_test.js | SMS App Unit-Test Threads-list Threads-list rendering Update thread with contact name - expected '1977' to equal 'Pepito O\'Hare'
14:18:18 INFO - Error: expected '1977' to equal 'Pepito O\'Hare'
14:18:18 INFO - at chaiAssert (app://sms.gaiamobile.org/common/test/helper.js:31:1)
14:18:18 INFO - at equal (app://sms.gaiamobile.org/common/vendor/chai/chai.js:1245:1)
14:18:18 INFO - at (anonymous) (app://sms.gaiamobile.org/test/unit/sms_test.js:277:1)


I think this could be intermittent with the current mocha too.
Attached file github PR
Here is a Try run with new mocha and this patch, we don't see the issue anymore:

https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=43f8117f718e
Attachment #8507747 - Flags: review?(schung)
Likely comes from the change in bug 1003843
Blocks: 1003843
Comment on attachment 8507747 [details] [review]
github PR

Ya I believe it's related to the changes in bug 1003843. Only 1 nit and thanks for discovering this intermittent issue.

BTW it seems another intermittent issue in your submitted job. Have you seen this before?

02:30:07 INFO - TEST-UNEXPECTED-FAIL | sms/test/unit/compose_test.js | compose_test.js segmentInfo set type to mms if the text is very long - expected 'sms' to equal 'mms'
02:30:07 INFO - Error: expected 'sms' to equal 'mms'
02:30:07 INFO - at chaiAssert (app://sms.gaiamobile.org/common/test/helper.js:31:1)
02:30:07 INFO - at equal (app://sms.gaiamobile.org/common/vendor/chai/chai.js:1245:1)
02:30:07 INFO - at (anonymous) (app://sms.gaiamobile.org/test/unit/compose_test.js:1639:9)
Attachment #8507747 - Flags: review?(schung) → review+
AH right, will look into it too :)
I can't really reproduce the intermittent with compose; let's see if this happens again in the future.

Rebased and asking for landing once the tree reopens :)
Keywords: checkin-needed
Master: https://github.com/mozilla-b2g/gaia/commit/1e91414e077bd532dd745e6dc80401b9842e097e
Assignee: nobody → felash
Status: NEW → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S9 (21Nov)
You need to log in before you can comment on or make changes to this bug.