Closed Bug 1085284 Opened 6 years ago Closed 5 years ago

Implement URLSearchParams iterable<>

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: annevk, Assigned: baku)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file, 1 obsolete file)

URLSearchParams now gained the IDL iterable<> member. We should support it.
Keywords: dev-doc-needed
It seems we don't support iteralbe<> in our webIDL codegen.
Depends on: 1085293
Blocks: 887836
Assignee: nobody → amarchesini
Attached patch iterable1.patch (obsolete) — Splinter Review
Attachment #8675439 - Flags: review?(bzbarsky)
Comment on attachment 8675439 [details] [diff] [review]
iterable1.patch

>+      is(key.value, v.toString(), "Correcy Key iterator: " + v.toString());

s/Correcy/Correct/, and same elsewhere in this test.

You probably want to assert that key.done/value.done/entry.done are false in the loop.

r=me
Attachment #8675439 - Flags: review?(bzbarsky) → review+
Attached patch iterable1.patchSplinter Review
Attachment #8675439 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/c1ff09b2e8fa
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.