Closed
Bug 1085300
Opened 10 years ago
Closed 10 years ago
[Loop][Testing] Basic test infrastructure with grunt
Categories
(Firefox OS Graveyard :: Gaia::Loop, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ferjm, Assigned: ferjm)
References
Details
Attachments
(1 file)
No description provided.
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → ferjmoreno
Blocks: Loopmov_1_1
|
|
Assignee | |
Comment 1•10 years ago
|
||
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8507806 -
Flags: review?(borja.bugzilla)
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8507806 -
Flags: review?(borja.bugzilla) → review?(josea.olivera)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8507806 [details] Link to Github pull-request: https://github.com/mozilla-b2g/firefoxos-loop-client/pull/215/files LGTM. r=me I left a comment on the PR. Basically I encourage you to add a default task (the tests one) but It's up to you. Some notes in the README file about the grunt stuff being added would be nice but at this point it is not really necessary. As you are moving everything to the app/ folder and it seems risky I ran kind of smoke test. Everything works and it seems nothing gets broken when taking this patch. The downside of taking this patch is when uplifting the patches we will still need on the 1.1 branch.
Attachment #8507806 -
Flags: review?(josea.olivera) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Thanks! The default task is added in bug 1085485 and I'll add the README today
|
|
Assignee | |
Comment 4•10 years ago
|
||
https://github.com/mozilla-b2g/firefoxos-loop-client/commit/f83a3c5aa90c0f78a8047c7efadace01ad01325b
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•