Closed
Bug 1085318
Opened 10 years ago
Closed 10 years ago
[mozdevice] Change the log level within DeviceManagerADB.getInfo to DEBUG
Categories
(Testing :: Mozbase, defect)
Testing
Mozbase
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla36
People
(Reporter: davehunt, Assigned: davehunt)
Details
Attachments
(1 file)
|
2.58 KB,
patch
|
wlach
:
review+
|
Details | Diff | Splinter Review |
DeviceManagerADB.getInfo currently logs the return value at INFO level. This isn't so bad when it's called to get the id or os info, but if all info is returned we get a lot of noise in the console. I'd like to set this level to DEBUG.
|
Assignee | |
Comment 1•10 years ago
|
||
I also added support for the logging to the command line tool (useful for testing this) and a prefix to the log so it's a bit clearer what it is we're logging.
Attachment #8507836 -
Flags: review?(wlachance)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8507836 [details] [diff] [review] Change log level in getInfo to debug. v1.0 Review of attachment 8507836 [details] [diff] [review]: ----------------------------------------------------------------- Looks great, thank you!
Attachment #8507836 -
Flags: review?(wlachance) → review+
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/bee3a048500b
Keywords: checkin-needed
|
|
||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/bee3a048500b
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•