1085380 - [Music] the open activities after the first open activity should play the audio normally.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Safwan Rahman (:safwan)]

# Turn on the Bluetooth of the Device and pair any other Device.
# Open the Music app and play any music
# While playing the music, transfer any Audio file from the paired device to your Firefox OS device with Bluetooth.
# Accept the file transfer and the file will be downloaded into your Device.
# After transfer complete, Drag down the Notification bar and play the downloaded Audio file.
# While playing the downloaded file, send another Audio file to the Firefox OS Device
# Accept the file transfer and the file will be downloaded into your Device.
# After transfer complete, Drag down the Notification bar and play the downloaded Audio file.

Actual Result:
# The Audio File will not be played

Expected result:
# The Audio File should be played
 
Reproduce rate: 5/5

Its affecting B2G 2.0 and 2.1.
According to bug 1075353 comment 35, its a bug of gecko
According to bug 1075353 comment 11, its affected on Gecko: 652c5d4, Version: 35.0a1, buildID: 20141008012326
According to bug 1075353 comment 18, its not affected on Gecko: ad3210dd8e400d91fd115fd18f40c45f0ece3c1e, Version: 35.0a1, BuildID: 20141012161832

Comment 1

[Safwan Rahman (:safwan)]

[Blocking Requested - why for this release]: According to bug 1075353 comment 19, it is blocking 2.0. So requesting this bug also to be marked as blocking 2.0

from bug 1075353 comment 19
>Triage to set it to 2.0+ ; 100% reproduce rate,reproducible on master, besides partner requested this as blocker.

Comment 2

[(Inactive after June) George Duan [:gduan] [:喬智]]

When system receives an activity, it launches an activity window and points to that app's activity html. When 2nd activity is sent, gecko will sent to the first activity window instead of new one. That's why we  ignore same manifestUrl/url activity request in child_window_factory.js.

Comment 3

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

This patch fixes music/open to let open.js play 2nd activity successfully.

Comment 4

[Rachelle Yang [:ryang][[e-mail]]]

Hi Safwan,

Could you please kindly try the patch in comment3 on 2.2 for us ? 
This could help us speed up the triage to weight its importance and effectiveness. 

Thank you very much !

Comment 5

[Dominic Kuo [:dkuo]]

Changing the title to fit the reality.

Comment 6

[Dominic Kuo [:dkuo]]

Comment on attachment 8508444 [details] [review]
PR to master

Thanks George, the patch looks good to me base on comment 2, the music open activity did not expect there are more activities will come after the first one, so stop the player then play the new received file make sense to me.

Comment 7

[Rachelle Yang [:ryang][[e-mail]]]

Triage to set it to 2.0 +

Comment 8

[Safwan Rahman (:safwan)]

(In reply to Rachelle Yang [:ryang][[e-mail]] from comment #4)
> Hi Safwan,
> 
> Could you please kindly try the patch in comment3 on 2.2 for us ? 
> This could help us speed up the triage to weight its importance and
> effectiveness. 
> 
> Thank you very much !

It seems that the patch has fixed the issue. Thanks george.

Comment 9

[Safwan Rahman (:safwan)]

George, as the PR has been reviewed and the patch has been verified, can you please merge it at master?
Also, as this blocks 2.0+, can you please make uplift for 2.0 and 2.1?

Comment 10

[(Inactive after June) George Duan [:gduan] [:喬智]]

master: https://github.com/mozilla-b2g/gaia/commit/725350a4167239b864feee620d1af4082ebfabac

Comment 11

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8508444 [details] [review]
PR to master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): No.
[User impact] if declined: user cannot played 2nd incoming music through activity like bluetooth.
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky): No
[String changes made]:

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): No
[User impact] if declined: if declined: user cannot played 2nd incoming music through activity like bluetooth.
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky): No
[String changes made]:

Comment 12

[bhavana bajaj [:bajaj]]

Comment on attachment 8508444 [details] [review]
PR to master

Requesting QA verification once this lands on 2.0 and 2.1.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/39721f8cf0d4afcde11091dc617108e8d27ca876

Comment 14

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/786d14289c430d22fbd6c9f42c2c74f870abf34a

Comment 15

[sarsenyev]

Verified, the issue is fixed on 2.2, 2.1 and 2.0

Additional transferred audio file plays with no issues

Device: Flame 2.2 Master KK
BuildID: 20141028040202
Gaia: 6a7fb482a03c5083ef79b41e7b0dfab27527cd04
Gecko: a255a234946e
Gonk: 6e51d9216901d39d192d9e6dd86a5e15b0641a89
Version: 36.0a1 (2.2 Master)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Device: Flame 2.1 KK
BuildID: 20141028001203
Gaia: a0174f7166745256aaca1cb3aa9f894033fbffa6
Gecko: 43bda3541f6b
Gonk: 6e51d9216901d39d192d9e6dd86a5e15b0641a89
Version: 34.0 (2.1)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Device: Flame 2.0 KK
BuildID: 20141028000202
Gaia: 5e532a84e762b1bb6231756182cf1465671a061e
Gecko: 124f0bed1700
Gonk: 6e51d9216901d39d192d9e6dd86a5e15b0641a89
Version: 32.0 (2.0)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 16

[Coler]

Verify passed, this issue can't be repro on Woodduck 2.0.
Attached: Verify_Woodduck_BTmusic.mp4
Reproducing rate: 0/5

Woodduck build:
Gaia-Rev        cc690f8016b672475dc186bc7fd58aef45e684b7
Gecko-Rev       03d3ab62d5b07b915434f2d1d68495ad5915ecd2
Build-ID        20141118184148
Version         32.0

Comment 17

[Coler]

Attachment: Verify_Woodduck_BTmusic.MP4