1085384 - A key's uppercase data is incorrect for layouts that has explicit upperCase mapping

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

STR:

1. Build and switch to Korean layout
2. Hit shift to switch to upper case state.
3. Inspect the key on the top left 

Expected:

1. Should be "ㅃ"

Actual:

1. Character remain "ㅂ"


John, without working on the regression window, you are most likely the offender here. Would you mind check it? Thanks.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

This blocks my work on moving the rendering around in bug 1085359.

I can confirm this is a layout normalization issue because this is what app.layoutManager.currentPage.keys[0][0] prints:

{ value: "ㅂ", keyCode: 12610, keyCodeUpper: 12610, lowercaseValue: "ㅂ", uppercaseValue: "ㅂ", isSpecialKey: false }

Comment 2

[John Lu [:mnjul][Please NI or I'll miss]]

On my way. Keeping NI for reminding.

Comment 3

[John Lu [:mnjul][Please NI or I'll miss]]

Yeah I found the cause. Patch is on the way.

Comment 4

[John Lu [:mnjul][Please NI or I'll miss]]

Attachment: Patch (PR @ GitHub)

The normalization's getUpperCase() looked up upperCase dictionary in a wrong place. It has been fixed.

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Please point to the regressed bug at the "Blocks" field.

Comment 6

[John Lu [:mnjul][Please NI or I'll miss]]

Master: https://github.com/mozilla-b2g/gaia/commit/056edb5bdbf31c3878ee01bdef0a67fa194c100e

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Blocking 2.2+ for all fixed regressions.

Comment 8

[Yeojin Chung [:YeojinC]]

This bug is not fixed on Flame 2.2.

Result: "ㅔ" and "ㅐ" remain on the keyboard when the shift key is pressed.

Environmental Variables:
Device: Flame 2.2 Master
BuildID: 20141121040204
Gaia: e5d666d6f62480ced56c6d9352f5e12befb5a862
Gecko: 3366c0fcf9c2
Version: 36.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0
==============================================================

Filed a new bug 1104358.