1085497 - Use typedef for the length of mozilla::pkix::Input/Reader for safer casting

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Attachment: size_type.patch

Let's say you want to compute the diference of lengths of to Inputs:

   Input::size_type diff;
   if (a.GetLength() > b.GetLength()) {
     // The cast is required because operator- returns a signed type.
     diff = static_cast<Input::size_type>(a.GetLength() - b.GetLength());
   }

We could just use "uint16_t" but that would be problematic if/when we need to change the maximum length of Input/Reader.

Comment 1

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9d83b21c98e8

Thanks for the quick review.

Comment 2

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9d83b21c98e8