1085550 - Intermittent failing test, Vertical - Group collapse the first group | AssertionError: false == true

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Kevin Grandon :kgrandon]

https://taskcluster-artifacts.s3-us-west-2.amazonaws.com/BIsjm33YSFml8mSRxMULdQ/4/public/marionette_js_tests/debug.log?AWSAccessKeyId=AKIAIZOQG4W6WG3PH3RQ&Expires=1413833659&Signature=RD2ox70erLop6GWeqfo7scr8tIY%3D

1) Vertical - Group collapse the first group:
     
  AssertionError: false == true
      at Context.<anonymous> (/home/tester/git_checkout/apps/verticalhome/test/marionette/group_collapse_test.js:55:12)
      at callFn (/home/tester/git_checkout/node_modules/mocha/lib/runnable.js:223:21)
      at Test.Runnable.run (/home/tester/git_checkout/node_modules/mocha/lib/runnable.js:216:7)
      at Runner.runTest (/home/tester/git_checkout/node_modules/mocha/lib/runner.js:373:10)
      at /home/tester/git_checkout/node_modules/mocha/lib/runner.js:451:12
      at next (/home/tester/git_checkout/node_modules/mocha/lib/runner.js:298:14)
      at /home/tester/git_checkout/node_modules/mocha/lib/runner.js:308:7
      at next (/home/tester/git_checkout/node_modules/mocha/lib/runner.js:246:23)
      at /home/tester/git_checkout/node_modules/mocha/lib/runner.js:270:7
      at done (/home/tester/git_checkout/node_modules/mocha/lib/runnable.js:185:5)
      at callFn (/home/tester/git_checkout/node_modules/mocha/lib/runnable.js:228:7)
      at Hook.Runnable.run (/home/tester/git_checkout/node_modules/mocha/lib/runnable.js:216:7)
      at next (/home/tester/git_checkout/node_modules/mocha/lib/runner.js:258:10)
      at /home/tester/git_checkout/node_modules/mocha/lib/runner.js:270:7
      at done (/home/tester/git_checkout/node_modules/mocha/lib/runnable.js:185:5)
      at /home/tester/git_checkout/node_modules/mocha/lib/runnable.js:199:9
      at Object.executeHook (/home/tester/git_checkout/node_modules/marionette-client/lib/marionette/client.js:369:18)
      at process._tickCallback (node.js:419:13)

Comment 1

[Kevin Grandon :kgrandon]

Disabled in: https://github.com/mozilla-b2g/gaia/commit/457a54fc3200b80e4f5e1cd3acaa062309230732

Comment 2

[Kevin Grandon :kgrandon]

Something we need to fix. I will take a look unless you beat me to it.

Comment 3

[Chris Lord [:cwiiis]]

Taking a look.

Comment 4

[Chris Lord [:cwiiis]]

Interestingly, this is failing pretty consistently for me locally, but it wasn't before... It's just not collapsing the group :/

Comment 5

[Chris Lord [:cwiiis]]

Attachment: Fix group_collapse_test.js

Seems the method of waiting for the element to come into view isn't reliable (anymore?), so just replaced it with a wait. Possibly it also needed to wait for a transition... I think there are marionette bugs on file that will provide more reliable ways of doing this but this seems reasonable enough to me for now.

Comment 6

[Kevin Grandon :kgrandon]

Comment on attachment 8508637 [details] [review]
Fix group_collapse_test.js

lgtm, let's try it!

Comment 7

[Kevin Grandon :kgrandon]

In master: https://github.com/mozilla-b2g/gaia/commit/b5ab2c6bc85b3663777818387e5eb598347e4afc

Comment 8

[Firefox Bug Husbandry Bot]

Removing leave-open keyword from resolved bugs, per :sylvestre.