Closed Bug 1085592 Opened 10 years ago Closed 9 months ago

<video> volume control doesn't activate after swapping src

Categories

(Core :: Audio/Video: Playback, defect)

defect

Tracking

()

VERIFIED FIXED
127 Branch
Tracking Status
firefox127 --- verified
firefox128 --- verified

People

(Reporter: me, Assigned: gregp)

Details

Attachments

(2 files)

STR: 1) Create a <video> 2) Set src to a video without an audio track 3) Set src to a video with an audio track 4) Volume control stays in disabled state I'll provide a fiddle in the next days.
Component: Audio/Video → Audio/Video: Playback
Can you provide test html?
Severity: normal → S3
Attached file volume.html

Firefox 126 remains affected.

Assignee: nobody → gregp
Status: NEW → ASSIGNED
Pushed by gp3033@protonmail.com: https://hg.mozilla.org/integration/autoland/rev/0e11dd151dee Enable mute button when video src is changed from a video without sound to a video with sound r=emilio,reusable-components-reviewers,mconley,mstriemer

Backed out for causing mochitest failures in test_videocontrols_video_noaudio.html

[task 2024-05-02T23:56:19.660Z] 23:56:19     INFO -  TEST-START | toolkit/content/tests/widgets/test_videocontrols_video_noaudio.html
[task 2024-05-02T23:56:19.660Z] 23:56:19     INFO -  Buffered messages logged at 23:56:11
[task 2024-05-02T23:56:19.660Z] 23:56:19     INFO -  add_task | Entering setup
[task 2024-05-02T23:56:19.660Z] 23:56:19     INFO -  add_task | Leaving setup
[task 2024-05-02T23:56:19.661Z] 23:56:19     INFO -  add_task | Entering mute_button_icon
[task 2024-05-02T23:56:19.661Z] 23:56:19     INFO -  Buffered messages finished
[task 2024-05-02T23:56:19.661Z] 23:56:19  WARNING -  TEST-UNEXPECTED-FAIL | toolkit/content/tests/widgets/test_videocontrols_video_noaudio.html | undefined assertion name - got "", expected "true"
[task 2024-05-02T23:56:19.661Z] 23:56:19     INFO -      SimpleTest.is@SimpleTest/SimpleTest.js:509:14
[task 2024-05-02T23:56:19.661Z] 23:56:19     INFO -      mute_button_icon@toolkit/content/tests/widgets/test_videocontrols_video_noaudio.html:32:7
[task 2024-05-02T23:56:19.661Z] 23:56:19     INFO -      nextTick/<@SimpleTest/SimpleTest.js:2189:34
[task 2024-05-02T23:56:19.661Z] 23:56:19     INFO -      async*nextTick@SimpleTest/SimpleTest.js:2233:11
[task 2024-05-02T23:56:19.661Z] 23:56:19     INFO -      setTimeout handler*SimpleTest_setTimeoutShim@SimpleTest/SimpleTest.js:922:41
[task 2024-05-02T23:56:19.661Z] 23:56:19     INFO -      add_task@SimpleTest/SimpleTest.js:2137:17
[task 2024-05-02T23:56:19.661Z] 23:56:19     INFO -      @toolkit/content/tests/widgets/test_videocontrols_video_noaudio.html:23:11
[task 2024-05-02T23:56:19.661Z] 23:56:19     INFO -  TEST-PASS | toolkit/content/tests/widgets/test_videocontrols_video_noaudio.html | Mute button should be disabled
Flags: needinfo?(gregp)
Pushed by gp3033@protonmail.com: https://hg.mozilla.org/integration/autoland/rev/c665bcd1d673 Enable mute button when video src is changed from a video without sound to a video with sound r=emilio,reusable-components-reviewers,mconley,mstriemer
Regressions: 1894845
No longer regressions: 1894845
Flags: needinfo?(gregp)
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → 127 Branch

Reproducible on a 2024-05-01 Nightly build on Windows 10.
Verified as fixed on Firefox Nightly 128.0a1 and Firefox 127.0b2 on Windows 10, macOS 12, Ubuntu 22.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: