1085595 - Move hard-coded strings in testDoorHanger into StringHelper

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Testing, defect)

Description

[:Margaret Leibovic]

We declare local variables for a lot of strings in here:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/tests/testDoorHanger.java

Instead, we should declare them here:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/tests/StringHelper.java

For details about running robocop tests locally, see this documentation:
https://wiki.mozilla.org/Mobile/Fennec/Android#Robocop

Comment 1

[Yasaswy Kota]

Can I work on this?

Comment 2

[vikneshwar]

Attachment: moved-to-StringHelper.patch

Comment 3

[:Margaret Leibovic]

(In reply to Yasaswy Kota [:caber] from comment #1)
> Can I work on this?

Hi Yasaswy, unfortunately, it looks like vikneshwar beat you to this bug. Let me know if you need help finding another bug! We'd love to see you get involved!

Comment 4

[:Margaret Leibovic]

Comment on attachment 8508903 [details] [diff] [review]
moved-to-StringHelper.patch

Review of attachment 8508903 [details] [diff] [review]:
-----------------------------------------------------------------

Looking good! I made a try push:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=0b8826a204cd

If it's green, we can land it. You've been doing a lot of great work, let me know if you need help finding more challenging bugs! It would be nice to leave these [good first bugs] for first-timers :)

::: mobile/android/base/tests/StringHelper.java
@@ +251,5 @@
> +    public static final String LOGIN_MESSAGE = "Save password";
> +    public static final String LOGIN_ALLOW = "Save";
> +    public static final String LOGIN_DENY = "Don't save";
> +
> +    //Strings used in popup

Nit: These strings are used in the popup-blocking doorhanger, not in a popup. We can remove this comment since the comment above about doorhanger messages and buttons applies here.

Comment 5

[Yasaswy Kota]

(In reply to :Margaret Leibovic from comment #3)
> (In reply to Yasaswy Kota [:caber] from comment #1)
> > Can I work on this?
> 
> Hi Yasaswy, unfortunately, it looks like vikneshwar beat you to this bug.
> Let me know if you need help finding another bug! We'd love to see you get
> involved!

Hi Margaret, it would be great if you can find something that I help out with!

Comment 6

[vikneshwar]

Attachment: final.patch

Removed the comment :)

Comment 7

[:Margaret Leibovic]

Comment on attachment 8509525 [details] [diff] [review]
final.patch

Review of attachment 8509525 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks! And the try run looks green, so we can land this.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/3df00a905527

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3df00a905527