Closed Bug 1085696 Opened 5 years ago Closed 5 years ago

Move files in widget/xpwidgets/* and widget/shared/* into widget/

Categories

(Core :: Widget, defect)

26 Branch
x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: mchang, Assigned: mchang)

Details

Attachments

(2 files, 4 obsolete files)

From irc, shared widget code should go in mozilla-central/widget/shared but lots of shared widget code exists in widget/xpwidget/. Xpwidget isn't a very descriptive name compared to shared. Move the files from the xpwidget directory to the shared directory. 

This patch moves the files from widget/xpwidget to widget/shared. It also updates local includes that referenced /widget/xpwidget to /widget/shared. Finally, it merges the moz.build from /widget/shared and /widget/xpwidgets. We can update references to widget/xpwidget/moz.build in another patch. Does this also mean we should delete /widget/xpwidget as a directory?
Attachment #8508308 - Flags: review?(roc)
Hmm, bugzilla doesn't show moves in the review view. The raw patch has file renames.
Assignee: nobody → mchang
Comment on attachment 8508308 [details] [diff] [review]
Move files in widget/xpwidget to widget/shared

Review of attachment 8508308 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, but I've got an even better idea: let's move widget/xpwidgets/* and widget/shared/* into widget/.
Attachment #8508308 - Flags: review?(roc) → review-
Summary: Move files from widgets/xpwidgets to widgets/shared/ → Move files in widget/xpwidgets/* and widget/shared/* into widget/
WIP to move just /widget/xpwidgets into /widget. Will move /widget/shared directory in part 2. Most of the work is in merging /widget/xpwidgets/moz.build and /widget/moz.build. Treeherder build - https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=43c02a7e746f
Attachment #8508308 - Attachment is obsolete: true
From comment 2. Part 1 moves files in /widget/xpwidgest into /widget and the respective moz.build files. Also merged /widget/shared/WidgetUtils.h into /widget/WidgetUtils.h.
Attachment #8509102 - Attachment is obsolete: true
Attachment #8509762 - Flags: review?(roc)
Moves the remaining files in /widget/shared to /widget along with their respective moz.build files. 

Successful try build - https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=22ec0da91152

Also tested with non-unified builds on Linux.
Attachment #8509764 - Flags: review?(roc)
Carrying r+, rebased for master.
Attachment #8509762 - Attachment is obsolete: true
Attachment #8509975 - Flags: review+
Carrying r+. Rebased on master. Treeherder build: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=92350efecec6
Attachment #8509764 - Attachment is obsolete: true
Attachment #8509976 - Flags: review+
You need to log in before you can comment on or make changes to this bug.