1085730 - OrangeFactor UI revisions should link to Treeherder instead of TBPL

Status: RESOLVED FIXED

(Tree Management Graveyard :: OrangeFactor, defect)

Description

[Ed Morley [:emorley]]

https://hg.mozilla.org/automation/orangefactor/file/aea03f25712e/html/index.html#l217

Note the repo names are different to TBPL - they actually match the buildbot 'branch' (also the repo directory name) now. See the "name" property in:
https://github.com/mozilla/treeherder-service/blob/master/treeherder/model/fixtures/repository.json

Comment 1

[Ed Morley [:emorley]]

Attachment: Revisions in the UI should link to Treeherder instead of TBPL

The branchnames used by OrangeFactor are in fact compatible with Treeherder, since they are actually the base repo names, not the TBPL customised names that many other tools used; so this straight-forwards substitution works :-)

Comment 2

[Mark Côté [:mcote]]

Comment on attachment 8536241 [details] [diff] [review]
Revisions in the UI should link to Treeherder instead of TBPL

Review of attachment 8536241 [details] [diff] [review]:
-----------------------------------------------------------------

I shall take your word that that URL is correct. :)

Comment 3

[Ed Morley [:emorley]]

Thanks :-)

I deployed this along with bug 1085728, though in the case of this bug, it turns out the code was unused after all - have filed bug 1111755 to clean it up.

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/automation/orangefactor/rev/ef1256e981f3