Closed Bug 1086258 Opened 11 years ago Closed 8 years ago

For the single revision case, the "count=10" parameter is redundant

Categories

(Tree Management :: Treeherder, defect, P4)

Product:
Tree Management
Component:
Treeherder
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: emorley, Assigned: KWierso)

Details

Attachments

(1 file)

[treeherder] KWierso:b1086258 > mozilla:master
47 bytes, text/x-github-pull-request
emorley
: review+
Details | Review
Open a single revision page, with the web console open, eg: https://treeherder.mozilla.org/ui/#/jobs?repo=mozilla-central&revision=29fbfc1b31aa Note that the API request for the result set is: https://treeherder.mozilla.org/api/project/mozilla-central/resultset/?count=10&format=json&full=true&revision=29fbfc1b31aa&with_jobs=false The "count=10" seems redundant, since we're requesting a single revision, not "the 10 most recent from mozilla-central": https://github.com/mozilla/treeherder-ui/blob/79f71e0044a828732d7a3169af0aca641e9497f6/webapp/app/js/services/resultsets.js#L68
Priority: P3 → P4
Assignee: nobody → wkocher
Comment on attachment 8884126 [details] [review] [treeherder] KWierso:b1086258 > mozilla:master Awesomel - thank you! :-)
Attachment #8884126 - Flags: review?(emorley) → review+
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/f6fbfc03806c32c4feb7d00b32cb1685e4ac3322 Bug 1086258 - Only fetch a single resultset if revision is a url parameter (#2621) r=emorley
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: