1086269 - Add a test to set up a conference call

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P2)

Description

[Johan Lorenzo [:jlorenzo]]

Bug 1005862 and bug 1083402 are regressions on the same piece of code in the Dialer. We don't cover conference calls with automation. Let's fix that.

Then we would be able to check the regression on the notification in another bug.

Comment 1

[Johan Lorenzo [:jlorenzo]]

Attachment: Gaia PR

Asking Zac for review because I added a new helper to kill active calls in gaia_test.py: https://github.com/mozilla-b2g/gaia/pull/25369/files#diff-6d544bbb7c759ffb68f344f348f7740eR380

Comment 2

[Johan Lorenzo [:jlorenzo]]

(In reply to Johan Lorenzo [:jlorenzo] (QA) from comment #1)
> I added a new helper to kill active calls
I meant active conference calls. I'm using the same loop as they do in the callscreen: https://github.com/mozilla-b2g/gaia/blob/master/apps/callscreen/js/calls_handler.js#L579-L587

Comment 3

[Zac C (:zac)]

Putting jlorenzo to the test: http://jenkins1.qa.scl3.mozilla.com/job/flame-kk.ui.adhoc/224/console

Comment 4

[Zac C (:zac)]

Comment on attachment 8508732 [details] [review]
Gaia PR

r+ but I'm relying on the adhoc job to assert the functionality as I don't have a local Plivo account.

Comment 5

[Viorela Ioia [:viorela]]

Comment on attachment 8508732 [details] [review]
Gaia PR

r+, nice test!

Comment 6

[Zac C (:zac)]

btw Johan, is this a smoketest? in that case you need to add it to the manifest files.

Comment 7

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8508732 [details] [review]
Gaia PR

No, it's not. This test doesn't appear in this suite: https://moztrap.mozilla.org/manage/cases/?&pagenumber=1&pagesize=100&sortfield=created_on&sortdirection=desc&filter-productversion=217&filter-suite=678

I added the test in the manifest file. My PR is ready to merge then.

Comment 8

[Johan Lorenzo [:jlorenzo]]

Is it possible to merge it?

Comment 9

[Viorela Ioia [:viorela]]

Merged in: https://github.com/mozilla-b2g/gaia/commit/8ae6598f3ab7b0c34ac42a73083ddb74266affba

I'll leave this bug opened as the patch needs uplift to v2.1. Johan, can you uplift this? Thanks!

Comment 10

[Johan Lorenzo [:jlorenzo]]

Attachment: Gaia PR 2.1

Tested on 2.1 and passing.

Comment 11

[Viorela Ioia [:viorela]]

Merged in v2.1: https://github.com/mozilla-b2g/gaia/commit/224dfde17af943b583aa0a97936343c7267c7996