(App-grouping) Groups should have alternating background shading

VERIFIED FIXED in Firefox OS master

Status

VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: cwiiis, Assigned: cwiiis)

Tracking

unspecified
2.1 S7 (24Oct)
All
Gonk (Firefox OS)

Firefox Tracking Flags

(b2g-master verified)

Details

(Whiteboard: [systemsfe])

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
As in v0.4 of the spec, groups have alternating background shading. I've prototyped this already, will work it into a pull request + test: https://github.com/Cwiiis/gaia/tree/proto-grouping-refinements
(Assignee)

Comment 1

4 years ago
Created attachment 8508780 [details] [review]
Add alternating group background colours

Not a big change so one review is ok, but do pass it along to crdlc if your queue is huge already (picked kgrandon because of favourable timezone match-up)
Attachment #8508780 - Flags: review?(kgrandon)
Comment on attachment 8508780 [details] [review]
Add alternating group background colours

Looks good to me.
Attachment #8508780 - Flags: review?(kgrandon) → review+
(Assignee)

Comment 3

4 years ago
Merged: https://github.com/mozilla-b2g/gaia/commit/51f363f386051342e210fc2f41fe159c44754312
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [systemsfe]
Target Milestone: --- → 2.1 S7 (24Oct)
Verified fixed on the latest Nightly Flame 3.0 build

Results: Groups have alternating background shading 

Device: Flame 3.0 (KK - Nightly - Full Flash)
Build ID: 20150209010211
Gaia: 0d7b35f23402c4cb29bca6b98280fec48a196dec
Gecko: 3436787a82d0
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage?]
status-b2g-master: --- → verified
Flags: needinfo?(ktucker)
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
You need to log in before you can comment on or make changes to this bug.