Closed Bug 1086563 Opened 10 years ago Closed 10 years ago

Write test to verify offline behaviour of the RocketBar

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::UI Tests
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Bebe, Assigned: Bebe)

References

Details

Attachments

(1 file, 1 obsolete file)

Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25703
46 bytes, text/x-github-pull-request
zcampbell
: review+
Details | Review 
Write test for https://moztrap.mozilla.org/manage/case/14601/



    Go into Settings and turn on Airplane mode. Confirm wifi is also disabled.

    All network connections are turned off and you are not connected to wifi or data.

    Start typing in the Rocketbar.

    "No internet connection" is shown with a link to the Settings icon.

    Tap the Settings icon.

    The Network and Connectivity area of Settings should open.
Assignee: nobody → florin.strugariu
Please review my pull
Attachment #8509441 - Flags: review?(viorela.ioia)
Attachment #8509441 - Flags: review?(robert.chira)
Attachment #8509441 - Flags: review?(gmealer)
Comment on attachment 8509441 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25405

r+, with comments
Attachment #8509441 - Flags: review?(viorela.ioia) → review+
Comment on attachment 8509441 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25405

From PR: "Aside from naming typos and any questions/concerns posted, this looks good. I'd like to see those fixed or answered before merging, but otherwise LGTM pending Viorela and Robert's approvals."
Attachment #8509441 - Flags: review?(gmealer) → review+
Comment on attachment 8509441 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25405

SOrry, I'd like to review this again after comments are addressed. Thanks!
Attachment #8509441 - Flags: review+ → review-
Attachment #8509441 - Flags: review- → review?(viorela.ioia)
Attachment #8509441 - Flags: review?(viorela.ioia) → review-
Comment on attachment 8509441 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25405

Disabled the test on b2g desktop
Attachment #8509441 - Flags: review- → review?(viorela.ioia)
Depends on: 1091543
Uplift to v2.1?
Flags: needinfo?(florin.strugariu)
Attachment #8509441 - Flags: review?(robert.chira)
Reverted on master:
https://github.com/mozilla-b2g/gaia/commit/cf90923ae22528ed4e68fb3136a65a61626731cc

This patch still has a dependency.
Reopening this Zac can you review?
Attachment #8509441 - Attachment is obsolete: true
Flags: needinfo?(florin.strugariu)
Attachment #8515015 - Flags: review?(zcampbell)
Comment on attachment 8515015 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25703

r-, see git comments.
Attachment #8515015 - Flags: review?(zcampbell) → review-
Comment on attachment 8515015 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25703

Pull updated
Attachment #8515015 - Flags: review- → review?(zcampbell)
QA Whiteboard: fxosqa-auto-from-s2
QA Whiteboard: fxosqa-auto-from-s2 → fxosqa-auto-from-s2, fxosqa-auto-s3
QA Whiteboard: fxosqa-auto-from-s2, fxosqa-auto-s3 → [fxosqa-auto-from-s2] [fxosqa-auto-s3]
Comment on attachment 8515015 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25703

r+!
Attachment #8515015 - Flags: review?(zcampbell) → review+
Merged:
https://github.com/mozilla-b2g/gaia/commit/007da378c44e79778dfb48d610fae1a1e500d0c2
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: