Closed Bug 1086568 Opened 10 years ago Closed 7 years ago

checkVisible does not take scrollbars into account

Categories

(Remote Protocol :: Marionette, defect)

Product:
Remote Protocol
Component:
Marionette
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: davehunt, Unassigned)

References

Details

(Keywords: pi-marionette-displayed, pi-marionette-server)

Elements are be considered visible even when their interaction points are beneath scrollbars. This is because elementInViewport uses the window's innerHeight and innerWidth to determine the viewport. Window.innerHeight Height (in pixels) of the browser window viewport including, if rendered, the horizontal scrollbar. https://developer.mozilla.org/en-US/docs/Web/API/Window.innerHeight Window.innerWidth Width (in pixels) of the browser window viewport including, if rendered, the vertical scrollbar. https://developer.mozilla.org/en-US/docs/Web/API/Window.innerWidth We should instead determine the height/width excluding the scrollbars, otherwise attempting to click such elements will instead interact with the scrollbars.
We now use pointer interactability tests for determining if something is in view, so this should be resolved by that.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.