Closed
Bug 1086603
Opened 11 years ago
Closed 11 years ago
Add test test_browser_navigation.py to share a link to the SMS app
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect, P2)
Tracking
(b2g-v2.2 unaffected)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| b2g-v2.2 | --- | unaffected |
People
(Reporter: jlorenzo, Assigned: jlorenzo)
Details
Attachments
(2 files)
We need to automate this manual test: https://moztrap.mozilla.org/manage/case/2027/
| Assignee | ||
Updated•11 years ago
|
Summary: Add test/update test_browser_navigation.py to share a link to the SMS app → Add test test_browser_navigation.py to share a link to the SMS app
| Assignee | ||
Comment 1•11 years ago
|
||
I added a new test, test_browser_navigation does already a lot of stuff. It was inspired by test_browser_bookmark.py
Attachment #8508784 -
Flags: review?(robert.chira)
Attachment #8508784 -
Flags: review?(gmealer)
Comment 2•11 years ago
|
||
Comment on attachment 8508784 [details] [review]
Gaia PR
r-, comments in PR
Attachment #8508784 -
Flags: review?(robert.chira) → review-
| Assignee | ||
Comment 3•11 years ago
|
||
Comment on attachment 8508784 [details] [review]
Gaia PR
The things you pointed out should be fixed now.
Attachment #8508784 -
Flags: review- → review?(robert.chira)
Comment on attachment 8508784 [details] [review]
Gaia PR
LGTM, pending my minor naming comment and Robert's r+
Attachment #8508784 -
Flags: review?(gmealer) → review+
Comment 5•11 years ago
|
||
Comment on attachment 8508784 [details] [review]
Gaia PR
Merged on master:
https://github.com/mozilla-b2g/gaia/commit/dde9918a8e76cec4e29bb4f590cdc09dfbbe3cf2
Attachment #8508784 -
Flags: review?(robert.chira) → review+
Comment 6•11 years ago
|
||
Johan, can you uplift this to v2.1 please and check if it works as expected?
Flags: needinfo?(jlorenzo)
| Assignee | ||
Comment 7•11 years ago
|
||
Tested and working. Nothing had to be changed between the master PR and this one.
Flags: needinfo?(jlorenzo)
Attachment #8513352 -
Flags: review?(robert.chira)
Comment 8•11 years ago
|
||
Comment on attachment 8513352 [details] [review]
Gaia PR 2.1
Merged on v2.1:
https://github.com/mozilla-b2g/gaia/commit/151f0cf9c4bf92fde7462780af330667e163ac5f
Attachment #8513352 -
Flags: review?(robert.chira) → review+
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
QA Whiteboard: [fxosqa-auto-s2]
You need to log in
before you can comment on or make changes to this bug.
Description
•