Closed Bug 1086603 Opened 5 years ago Closed 5 years ago

Add test test_browser_navigation.py to share a link to the SMS app

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P2)

ARM
Gonk (Firefox OS)
defect

Tracking

(b2g-v2.2 unaffected)

RESOLVED FIXED
Tracking Status
b2g-v2.2 --- unaffected

People

(Reporter: jlorenzo, Assigned: jlorenzo)

Details

Attachments

(2 files)

Summary: Add test/update test_browser_navigation.py to share a link to the SMS app → Add test test_browser_navigation.py to share a link to the SMS app
Attached file Gaia PR
I added a new test, test_browser_navigation does already a lot of stuff. It was inspired by test_browser_bookmark.py
Attachment #8508784 - Flags: review?(robert.chira)
Attachment #8508784 - Flags: review?(gmealer)
Comment on attachment 8508784 [details] [review]
Gaia PR

r-, comments in PR
Attachment #8508784 - Flags: review?(robert.chira) → review-
Comment on attachment 8508784 [details] [review]
Gaia PR

The things you pointed out should be fixed now.
Attachment #8508784 - Flags: review- → review?(robert.chira)
Comment on attachment 8508784 [details] [review]
Gaia PR

LGTM, pending my minor naming comment and Robert's r+
Attachment #8508784 - Flags: review?(gmealer) → review+
Johan, can you uplift this to v2.1 please and check if it works as expected?
Flags: needinfo?(jlorenzo)
Attached file Gaia PR 2.1
Tested and working. Nothing had to be changed between the master PR and this one.
Flags: needinfo?(jlorenzo)
Attachment #8513352 - Flags: review?(robert.chira)
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
QA Whiteboard: [fxosqa-auto-s2]
You need to log in before you can comment on or make changes to this bug.