1086604 - [Loop] "Create new contact" and "Add to existing contact" not appear in long-press about a called registered in "calls" tab, when device makes a call to a contact with two or more mobiles and after this contact is deleted

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Loli (:lolimartinezcr)]

fireE (firee-kk-v2.0-SW2E3-1)
Loop version: 1.1 , 2168965


Prerequisites:
Device A with a contact saved with  name and two phones numbers (Loop clients: Device B and not Loop client Device C).

STRs:
1. Device A taps in "Contact" button in Loop application and selects a contact with two phones numbers (Loop clients: Device B and not Loop client Device C).
2. The video/audio call tries to be established 
3. After a few seconds Device A hangs up the video/audio call.
4. Loop application is closed (Loop application isn't working background)
5. (Device A) In contacts application, user deletes contact saved with  two phones numbers (Loop clients: Device B and not Loop client Device C).
6. Device A opens Loop application again, and now user can see called registered (step 3) with phones numbers .
7. Long-press in called registered.

Actual result: 
A new screen is opened with "Delete" and "Call" buttons.

Expected result:
A new screen is opened with "Create new contact", "Add to existing contact", "Delete" and "Call" buttons.

Comment 1

[Cristian Rodriguez (:crdlc)]

I cannot reproduce it, please Maria Angeles could you check this bug?

Comment 2

[Maria Angeles Oteo (:oteo)]

I am reproducing it too :( 
I think we can simplify the STR:

Prerequisites:
- Two devices registered in Loop with a valid identity (MSISDN or FxA).
- In the Address Book of device A we have the contact B kept with a name.


STRs:
1. User A tap on the Contact picker of Loop app to establish a Loop call with Contact B.
2. After that, there is an entry in the Call log of device A with the B contact name.
3. Go to the address book in Device A and delete Contact B so, in the entry of the Call log of Device A, the B identity is shown .
4. Long press on that entry

Current result: 
Menu opened with "Delete" and "Call" buttons.

Expected result:
Menu is opened with "Create new contact", "Add to existing contact", "Delete" and "Call" buttons.

It seems that when the contact B is deleted, although the B identity is correctly shown in the Call Log, the entry is not updated as available for adding it to the contact list so "Create new contact" and "Add to existing contact" options are not offered.

Comment 3

[Cristian Rodriguez (:crdlc)]

ñam ñan those STRs are reproducible for me too, fixing!!

Comment 4

[Cristian Rodriguez (:crdlc)]

Attachment: Github pull request

Thanks Fer

Comment 5

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8510087 [details]
Github pull request

LGTM. Thank you Cristian.

Comment 6

[Cristian Rodriguez (:crdlc)]

Merged in master:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/c4a704a54c4813c1a7226b6040adf98901e4c105

Comment 7

[Maria Angeles Oteo (:oteo)]

I've tested this bug in Loop master and it's working fine, although it's not a blocking issue it's a tiny patch so I think it's safe enough to uplift it to 2.0 so I am giving the approval.

Cristian, could you be so kind of meting the patch in v1.1 branch? Thanks a lot

Comment 8

[Cristian Rodriguez (:crdlc)]

in 1.1

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/42277e3647e893ee4844117889c15bd8ac1b42ee

Comment 9

[Javier de Prado]

Verified on flame:
user.v2.0.184based.B-49.Gecko-675d616.Gaia-2183b4f
eng.v2.0.184based.B-43.Gecko-675d616.Gaia-2183b4f
RAM: 5132M

FireE: v2.0-SW2E3-1

Loop Version 1.1: ofbfc03