1086614 - Compositor D3D11 doesn't handle device loss

Status: RESOLVED DUPLICATE of bug 1107718

(Core :: Graphics: Layers, defect)

Description

[Nicolas Silva [:nical]]

We know that this is not the cause for bug 1083071, but I want CompositorD3D11 to handle device loss before it becomes a problem.

Comment 1

[Nicolas Silva [:nical]]

Attachment: WIP untested patch

Comment 2

[Nicolas Silva [:nical]]

Attachment: WIP rebased on top of bug 1087270

Comment 3

[Nicolas Silva [:nical]]

Comment on attachment 8509553 [details] [diff] [review]
WIP rebased on top of bug 1087270

Review of attachment 8509553 [details] [diff] [review]:
-----------------------------------------------------------------

Bas, do you know if it is safe to call gfxPlatform::InitD3D11Devices a second time when the device is lost, and from the compositor thread (other than having to add a lock around GetDevice/InitDevice)?

Comment 4

[Bas Schouten (:bas.schouten)]

Comment on attachment 8509553 [details] [diff] [review]
WIP rebased on top of bug 1087270

Review of attachment 8509553 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/d3d11/CompositorD3D11.cpp
@@ +1112,5 @@
> +bool
> +CompositorD3D11::VerifyDevice()
> +{
> +  gfxWindowsPlatform::GetPlatform()->VerifyD3D11Device();
> +  if (mDevice != gfxWindowsPlatform::GetPlatform()->GetD3D11Device()) {

Why not return !!mDevice if mDevice == gfxWindowsPlatform::GetPlatform()->GetD3D11Device()?

@@ +1120,5 @@
> +  if (!mDevice && !Initialize()) {
> +    // Initialize can return false without clearing mDevice
> +    mDevice = nullptr;
> +    return false;
> +  }

Seems like you'd need to at least clear and recreate mSwapChain (and presumably some other stuff), in the device recreation case.

Comment 5

[Nicolas Silva [:nical]]

Attachment: handle removed devices

Comment 6

[Nicolas Silva [:nical]]

I am running into d3d11CreateDevice failing with DXGI_ERROR_UNSUPPORTED when I try to recreate the device after it has been reset (testing this by reinstalling my drivers while gecko is running). It's unclear what to do when this happens (basically no way to render to the screen when this happens, since we can't fallback to another backend).

Comment 7

[Nicolas Silva [:nical]]

Attachment: Handle removed device and crash if recreating the device fails

Updated patch, flagging for feedback rather than review since I haven't yet managed to recreate the device.

Comment 8

[Nicolas Silva [:nical]]

Attachment: Handle removed device and crash if recreating the device fails

The problem was that I didn't re-create the DXGI adapter. With this patch I was able to reinstall my graphics driver while Gecko is running without issue.