Closed
Bug 1086644
Opened 11 years ago
Closed 11 years ago
Devices won't unlock during performance tests
Categories
(Firefox OS Graveyard :: Gaia::PerformanceTest, defect)
Tracking
(b2g-v2.0 fixed, b2g-v2.0M fixed, b2g-v2.1 fixed, b2g-v2.2 fixed)
RESOLVED
FIXED
2.1 S7 (24Oct)
People
(Reporter: Eli, Assigned: Eli)
Details
(Keywords: perf, Whiteboard: [systemsfe])
Attachments
(2 files)
With bug 1080812 we had switched to using a marionette client setting to unlock the device, and while the performance tests do run, they technically run in the background behind the lockscreen. There doesn't seem to be any adverse effects, but we should revert back to *actually* unlocking the screen. We won't need this once pushing profiles to devices is supported.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #8508795 -
Flags: review?(jlal)
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #8508802 -
Flags: review?(jlal)
Comment 3•11 years ago
|
||
Comment on attachment 8508795 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25377
LGTM this is a fine hack for now.
Attachment #8508795 -
Flags: review?(jlal) → review+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 4•11 years ago
|
||
Keywords: checkin-needed
Comment 5•11 years ago
|
||
Master: https://github.com/mozilla-b2g/gaia/commit/58dc056af502bc7d1fb8d8a19dd99289917b5323
When you get a chance, please request Gaia v2.1 and v2.0 approval on these patches where appropriate :)
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
status-b2g-v2.0:
--- → affected
status-b2g-v2.0M:
--- → affected
status-b2g-v2.1:
--- → affected
status-b2g-v2.2:
--- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S7 (24Oct)
Comment 6•11 years ago
|
||
Nevermind, it's test-only. You can just re-set the checkin-needed once this looks green on master.
Assignee | ||
Comment 7•11 years ago
|
||
Comment on attachment 8508802 [details] [review]
Link to Github v2.0 pull-request: https://github.com/mozilla-b2g/gaia/pull/25378
Carrying over r+ from master patch to this identical change.
Attachment #8508802 -
Flags: review?(jlal) → review+
Assignee | ||
Comment 8•11 years ago
|
||
Need check in of test-only change to v2.1 for the master patch, and v2.0 for the v2.0 patch. Here is the try run for the v2.0 patch: https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=810c05b4b1b9
Whiteboard: checkin-needed
Comment 9•11 years ago
|
||
Updated•11 years ago
|
Whiteboard: [systemsfe]
Updated•11 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•