108666 - No context menu when right clicking on form text widgets

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect, P1)

Description

[doctor__j]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; rv:0.9.5+) Gecko/20011029
BuildID:    2001102906

Reproducible: Always

Steps to Reproduce:
1. Load the testcase.
2. Right-click on the textbox.
3. See the long and incorrect menu items shown.

Comment 1

[doctor__j]

Attachment: Testcase

Comment 2

[doctor__j]

Attachment: Screenshot

Comment 3

[rods (gone)]

over to kin for triage

Comment 4

[Boris Zbarsky [:bzbarsky]]

I see no context menu there at all on current linux.  Blake?

Comment 5

[Madhur Bhatia]

wfm on win2000 buildID: 2001-11-06-03 trunk build.

Comment 6

[doctor__j]

Now I can't see the context menu popping up at all !!
(using Win32 trunk build 2001110803)

Comment 7

[doctor__j]

Attachment: Screenshow of JS Console error (I can't copy those texts!!)

Comment 8

[Matthias Versen [:Matti]]

confirming with win2k build 20011108.. (CVS opt and debug)
The context menu is dead for textfields and I get the same JS errors: 
http://bugzilla.mozilla.org/showattachment.cgi?attach_id=57036
Madhur: 
Try it with a recent build in a URL field of a bug.
(It works in the comment field)

kin: Can you try to fix this for 0.9.6 ?

Comment 9

[kinmoz]

I'm putting it in 0.9.7, but I'll look into it asap.

Comment 10

[kinmoz]

Attachment: Patch Rev 1

This was caused by the JS Null string landing. We can no longer take shortcuts
like:

   node.getAttribute("foo").toUpperCase();

because getAttribute() now returns null instead of an empty string when "foo"
doesn't exist as an attribute. Blake, you'll probably want to do a sweep
through some of the browser JS files and make sure this isn't being done else
where ... we already went through this exercise in Composer.

Can I get an r= and sr= from blake and jst?

I'd like to get this in for 0.9.6 if possible.

Comment 11

[kinmoz]

Changing summary from:

  Very long and incorrect context menu is shown when right-clicking on textbox.

to:

  No context menu when right clicking on form text widgets

Comment 12

[Johnny Stenback (:jst)]

Comment on attachment 57649 [details] [diff] [review]
Patch Rev 1

sr=jst

Comment 13

[Blake Ross]

Comment on attachment 57649 [details] [diff] [review]
Patch Rev 1

r=blake

Comment 14

[kinmoz]

Checked in fix on trunk:

  mozilla/xpfe/communicator/resources/content/nsContextMenu.js  revision 1.44

I'm going to leave this bug open for now in hopes that I can land it on the
0.9.6 branch.

Comment 15

[Robert O'Callahan (:roc) (email my personal email if necessary)]

a=roc+moz for 0.9.6

Comment 16

[kinmoz]

Checked in fix on MOZILLA_0_9_6_BRANCH:

  mozilla/xpfe/communicator/resources/content/nsContextMenu.js  revision 1.43.2.1

Comment 17

[Madhur Bhatia]

verified fixed in trunk build : 2001-11-09-06trunk -- win2000

Comment 18

[Madhur Bhatia]

sorry ...... that is build ID: 2001-11-19-06trunk on win2000

Comment 19

[Madhur Bhatia]

marking verified fixed in win2000 branch build : 2001-11-20-03-0.9.6