1086676 - Add a test to check notification when you miss a call from a known contact.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Johan Lorenzo [:jlorenzo] - PTO - Back October 30th]

We experienced this regression in bug 994417. We can automate the following test case: https://moztrap.mozilla.org/manage/case/9294/

Comment 1

[Johan Lorenzo [:jlorenzo] - PTO - Back October 30th]

Attachment: Gaia PR

Would you mind reviewing this test Viorela?

Comment 2

[Viorela Ioia [:viorela]]

Comment on attachment 8509558 [details] [review]
Gaia PR

Looks good so far, but we can add some improvements.
See comments in the PR. Thanks!

Comment 3

[Johan Lorenzo [:jlorenzo] - PTO - Back October 30th]

Comment on attachment 8509558 [details] [review]
Gaia PR

Updated according your comments in the PR, Viorela!

Comment 4

[Robert Chira [:RobertC]]

Comment on attachment 8509558 [details] [review]
Gaia PR

The PR looks great, just a couple of comments to address.

Comment 5

[Johan Lorenzo [:jlorenzo] - PTO - Back October 30th]

Comment on attachment 8509558 [details] [review]
Gaia PR

Made the changes. Tell me what you think!

Comment 6

[Viorela Ioia [:viorela]]

Comment on attachment 8509558 [details] [review]
Gaia PR

Lgtm!

Comment 7

[Johan Lorenzo [:jlorenzo] - PTO - Back October 30th]

Last comments fixed. Commits squashed. Ready to merge!

Comment 8

[Viorela Ioia [:viorela]]

Merged in: https://github.com/mozilla-b2g/gaia/commit/b4601cae83dabd782f75286dfaa7fe1b0f176649

Comment 9

[Viorela Ioia [:viorela]]

Uplift to v2.1? Thanks!

Comment 10

[Johan Lorenzo [:jlorenzo] - PTO - Back October 30th]

Attachment: Gaia PR 2.1

Tested on 2.1 and passing.

Comment 11

[Johan Lorenzo [:jlorenzo] - PTO - Back October 30th]

Ready to merge!

Comment 12

[Viorela Ioia [:viorela]]

Merged in v2.1: https://github.com/mozilla-b2g/gaia/commit/ea6f9f10b2d537256cf8e6494e934e5c409e995e