Add a test to check notification when you miss a call from a known contact.

RESOLVED FIXED

Status

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jlorenzo, Assigned: jlorenzo)

Tracking

unspecified
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(b2g-v2.2 affected)

Details

Attachments

(2 attachments)

46 bytes, text/x-github-pull-request
viorela
: review+
Details | Review
46 bytes, text/x-github-pull-request
Details | Review
Assignee

Description

5 years ago
We experienced this regression in bug 994417. We can automate the following test case: https://moztrap.mozilla.org/manage/case/9294/
Assignee

Comment 1

5 years ago
Posted file Gaia PR
Would you mind reviewing this test Viorela?
Attachment #8509558 - Flags: review?(viorela.ioia)
Comment on attachment 8509558 [details] [review]
Gaia PR

Looks good so far, but we can add some improvements.
See comments in the PR. Thanks!
Attachment #8509558 - Flags: review?(viorela.ioia) → review-
Assignee

Comment 3

5 years ago
Comment on attachment 8509558 [details] [review]
Gaia PR

Updated according your comments in the PR, Viorela!
Attachment #8509558 - Flags: review?(viorela.ioia)
Attachment #8509558 - Flags: review?(robert.chira)
Attachment #8509558 - Flags: review-
Comment on attachment 8509558 [details] [review]
Gaia PR

The PR looks great, just a couple of comments to address.
Attachment #8509558 - Flags: review?(robert.chira) → review-
Assignee

Comment 5

5 years ago
Comment on attachment 8509558 [details] [review]
Gaia PR

Made the changes. Tell me what you think!
Attachment #8509558 - Flags: review?(robert.chira)
Attachment #8509558 - Flags: review-
Assignee

Updated

5 years ago
Attachment #8509558 - Flags: review?(robert.chira)
Comment on attachment 8509558 [details] [review]
Gaia PR

Lgtm!
Attachment #8509558 - Flags: review?(viorela.ioia) → review+
Assignee

Comment 7

5 years ago
Last comments fixed. Commits squashed. Ready to merge!
Flags: needinfo?(viorela.ioia)
Uplift to v2.1? Thanks!
Flags: needinfo?(jlorenzo)
Attachment #8509558 - Flags: review?(robert.chira)
Assignee

Comment 10

5 years ago
Posted file Gaia PR 2.1
Tested on 2.1 and passing.
Flags: needinfo?(jlorenzo)
Assignee

Comment 11

5 years ago
Ready to merge!
Flags: needinfo?(viorela.ioia)
Merged in v2.1: https://github.com/mozilla-b2g/gaia/commit/ea6f9f10b2d537256cf8e6494e934e5c409e995e
Status: NEW → RESOLVED
Closed: 5 years ago
Flags: needinfo?(viorela.ioia)
Resolution: --- → FIXED
QA Whiteboard: [fxosqa-auto-s2]
You need to log in before you can comment on or make changes to this bug.