1086705 - -Werror=switch causes TB build failure

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Joshua Cranmer [:jcranmer]]

Attachment: Revert -Werror=switch

tl;dr for anyone not present in the IRC conversation:

Thunderbird adds several nsresult error codes. These aren't in the nsresult enum. We switch on them.

Comment 1

[Nathan Froyd [:froydnj]]

Comment on attachment 8508831 [details] [diff] [review]
Revert -Werror=switch

Review of attachment 8508831 [details] [diff] [review]:
-----------------------------------------------------------------

We can argue about this elsewhere (perhaps on dev-platform?), but the status quo is that people make up their own nsresult error codes in Gecko already.  The (admittedly out-of-date!) documentation in nsError.h tells people exactly how to do this, even!  So I think requiring switches on nsresult to adhere to the blessed list of codes in nsErrorList.h is unreasonable.

It'd be an interesting experiment to convert nsresult to a structure type and see if that has adverse effects on performance...

Comment 2

[Joshua Cranmer [:jcranmer]]

https://hg.mozilla.org/mozilla-central/rev/f7ecd7ba118f

Comment 3

[Chris Peterson [:cpeterson]]

nsError.h could be configured so that comm-central uses the `typedef uint32_t nsresult` definition instead of the nsresult enum. Switching on a uint32_t nsresult would no longer generate -Wswitch warnings about out-of-range case values.